USB: apple-mfi-fastcharge: Fix use after free in probe
Subsystems (3)
PATCH 1/1 USB: apple-mfi-fastcharge: Fix use after free in probe
This code frees "mfi" and then derefences it on the next line to get the error code.
Fixes b0eec52fbe63 ("USB: apple-mfi-fastcharge: Fix kfree after failed kzalloc")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/usb/misc/apple-mfi-fastcharge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/misc/apple-mfi-fastcharge.c +3 -1
@@ -178,6 +178,7 @@ static int mfi_fc_probe(struct usb_device *udev) {struct power_supply_config battery_cfg = {};struct mfi_device *mfi =NULL ; +int err;if (!mfi_fc_match (udev))return -ENODEV ;
@@ -194,8 +195,9 @@ static int mfi_fc_probe(struct usb_device *udev) &battery_cfg);if (IS_ERR (mfi->battery)) {dev_err (&udev->dev,"Can't register battery\n" ); + err =PTR_ERR (mfi->battery);kfree (mfi); -return PTR_ERR (mfi->battery); +return err; } mfi->udev =usb_get_dev (udev);
Signature · 1 line
2.29.2
Quoted 6 lines · Dan Carpenter
This code frees "mfi" and then derefences it on the next line to get the error code.
Fixes b0eec52fbe63 ("USB: apple-mfi-fastcharge: Fix kfree afterfailed kzalloc")
Signed-off-by Dan Carpenter <[email protected]>
Thanks for catching that.
Reviewed-by Bastien Nocera <[email protected]>