Skip to contentSkip to conversation

mtd: rawnand: meson: Fix a resource leak in init

PATCH Applied Dan Carpenter 2 participants 2 messages Dec 3, 2020 – Dec 7, 2020

Subsystems (5)
Kernel janitors Memory technology devices (MTD) Arm/Amlogic Meson SoC support NAND flash +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 mtd: rawnand: meson: Fix a resource leak in init

Call clk_disable_unprepare(nfc->phase_rx) if the clk_set_rate() function fails to avoid a resource leak.

Fixes 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/mtd/nand/raw/meson_nand.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/mtd/nand/raw/meson_nand.c +4 -1
index a76afea6ea77..817bddccb775 100644
@@ -1044,9 +1044,12 @@ static int meson_nfc_clk_init(struct meson_nfc *nfc)
 
 	ret = clk_set_rate(nfc->device_clk, 24000000);
 	if (ret)
-		goto err_phase_rx;
+		goto err_disable_rx;
 
 	return 0;
+
+err_disable_rx:
+	clk_disable_unprepare(nfc->phase_rx);
 err_phase_rx:
 	clk_disable_unprepare(nfc->phase_tx);
 err_phase_tx:
Signature · 1 line
2.29.2