Input: gtco - remove driver
Subsystems (2)
Dmitry Torokhov
maintainerPATCH 1/1 Input: gtco - remove driver
The driver has its own HID descriptor parsing code, that had and still has several issues discovered by syzbot and other tools. Ideally we should move the driver over to the HID subsystem, so that it uses proven parsing code. However the devices in question are EOL, and GTCO is not willing to extend resources for that, so let's simply remove the driver.
Note that our HID support has greatly improved over the last 10 years, we may also consider reverting 6f8d9e26e7de ("hid-core.c: Adds all GTCO CalComp Digitizers and InterWrite School Products to blacklist") and see if GTCO devices actually work with normal HID drivers.
--- drivers/input/tablet/Kconfig | 12 - drivers/input/tablet/Makefile | 1 - drivers/input/tablet/gtco.c | 1043 --------------------- kernel/configs/android-recommended.config | 1 - 4 files changed, 1057 deletions(-)
drivers/input/tablet/Kconfig +0 -12
@@ -38,18 +38,6 @@ config TABLET_USB_AIPTEK To compile this driver as a module, choose M here: the module will be called aiptek. -config TABLET_USB_GTCO - tristate "GTCO CalComp/InterWrite USB Support" - depends on USB && INPUT - help - Say Y here if you want to use the USB version of the GTCO - CalComp/InterWrite Tablet. Make sure to say Y to "Mouse support" - (CONFIG_INPUT_MOUSEDEV) and/or "Event interface support" - (CONFIG_INPUT_EVDEV) as well. - - To compile this driver as a module, choose M here: the - module will be called gtco. - config TABLET_USB_HANWANG tristate "Hanwang Art Master III tablet support (USB)" depends on USB_ARCH_HAS_HCD
drivers/input/tablet/Makefile +0 -1
@@ -6,7 +6,6 @@ obj-$(CONFIG_TABLET_USB_ACECAD) += acecad.o obj-$(CONFIG_TABLET_USB_AIPTEK) += aiptek.o -obj-$(CONFIG_TABLET_USB_GTCO) += gtco.o obj-$(CONFIG_TABLET_USB_HANWANG) += hanwang.o obj-$(CONFIG_TABLET_USB_KBTAB) += kbtab.o obj-$(CONFIG_TABLET_USB_PEGASUS) += pegasus_notetaker.o
drivers/input/tablet/gtco.c deleted +0 -1043
1,043 lines not on this page · raw message
kernel/configs/android-recommended.config +0 -1
@@ -111,7 +111,6 @@ CONFIG_STRICT_KERNEL_RWX=y CONFIG_SUSPEND_TIME=y CONFIG_TABLET_USB_ACECAD=y CONFIG_TABLET_USB_AIPTEK=y -CONFIG_TABLET_USB_GTCO=y CONFIG_TABLET_USB_HANWANG=y CONFIG_TABLET_USB_KBTAB=y CONFIG_TASKSTATS=y
Signature · 5 lines
2.29.2.576.ga3fc446d84-goog -- Dmitry
Quoted 5 lines · Dmitry Torokhov
The driver has its own HID descriptor parsing code, that had and still has several issues discovered by syzbot and other tools. Ideally we should move the driver over to the HID subsystem, so that it uses proven parsing code. However the devices in question are EOL, and GTCO is not willing to extend resources for that, so let's simply remove the driver.
Quoted 5 lines
Note that our HID support has greatly improved over the last 10 years, we may also consider reverting
6f8d9e26e7de("hid-core.c: Adds all GTCO CalComp Digitizers and InterWrite School Products to blacklist") and see if GTCO devices actually work with normal HID drivers.
Sounds like a good plan to me. Perhaps you can do that in a series together, and stage that for 5.12?
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs
Dmitry Torokhov
maintainerHi Jiri,
Quoted 11 lines · Jiri Kosina
Quoted 5 lines · Dmitry Torokhov
The driver has its own HID descriptor parsing code, that had and still has several issues discovered by syzbot and other tools. Ideally we should move the driver over to the HID subsystem, so that it uses proven parsing code. However the devices in question are EOL, and GTCO is not willing to extend resources for that, so let's simply remove the driver.
Acked-by Jiri Kosina <[email protected]>Quoted 1 line
Quoted 7 lines
Quoted 4 lines
Note that our HID support has greatly improved over the last 10 years, we may also consider reverting
6f8d9e26e7de("hid-core.c: Adds all GTCO CalComp Digitizers and InterWrite School Products to blacklist") and see if GTCO devices actually work with normal HID drivers.Sounds like a good plan to me. Perhaps you can do that in a series together, and stage that for 5.12?
Sorry, I already zapped the driver in 5.11.
Unfortunately I do not have this hardware, so while we could remove these devices from the blacklist we will have to do that blindly. Please let me know if you still want to do that.
Thank you.
Signature · 1 line
Dmitry
Jiri Kosina
maintainerQuoted 5 lines · Dmitry Torokhov
Quoted 5 lines
Quoted 4 lines
Note that our HID support has greatly improved over the last 10 years, we may also consider reverting
6f8d9e26e7de("hid-core.c: Adds all GTCO CalComp Digitizers and InterWrite School Products to blacklist") and see if GTCO devices actually work with normal HID drivers.
Quoted 8 lines
Quoted 2 lines
Sounds like a good plan to me. Perhaps you can do that in a series together, and stage that for 5.12?
Sorry, I already zapped the driver in 5.11.
Unfortunately I do not have this hardware, so while we could remove these devices from the blacklist we will have to do that blindly. Please let me know if you still want to do that.
We can also wait for the first person to potentially complain (if ever) about the driver going away -- that'd mean that the person does actually still have that hardware, and we could ask him to test with hid-generic.
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs