kexec: Fix error code in kexec_calculate_store_digests()
Subsystems (4)
PATCH 1/1 kexec: Fix error code in kexec_calculate_store_digests()
Return -ENOMEM on allocation failure instead of returning success.
Fixes a43cac0d9dc2 ("kexec: split kexec_file syscall code to kexec_file.c")
Signed-off-by Dan Carpenter <[email protected]>
--- kernel/kexec_file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/kexec_file.c +3 -1
@@ -735,8 +735,10 @@ static int kexec_calculate_store_digests(struct kimage *image) sha_region_sz =KEXEC_SEGMENT_MAX *sizeof (struct kexec_sha_region ); sha_regions =vzalloc (sha_region_sz); -if (!sha_regions) +if (!sha_regions) { + ret = -ENOMEM ; goto out_free_desc; + } desc->tfm = tfm;
Signature · 1 line
2.29.2
Quoted 27 lines · Dan Carpenter
Return
-ENOMEMon allocation failure instead of returning success.Fixes a43cac0d9dc2 ("kexec: split kexec_file syscall code to kexec_file.c")Signed-off-by Dan Carpenter <[email protected]>--- kernel/kexec_file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)kernel/kexec_file.c +3
-1@@ -735,8 +735,10 @@ static int kexec_calculate_store_digests(struct kimage *image) sha_region_sz =KEXEC_SEGMENT_MAX *sizeof (struct kexec_sha_region ); sha_regions =vzalloc (sha_region_sz); -if (!sha_regions) +if (!sha_regions) { + ret = -ENOMEM ; goto out_free_desc; + } desc->tfm = tfm;Signature · 1 line
2.29.2
Good catch, thanks!
Acked-by Dave Young <[email protected]>
Thanks
Dave