Skip to contentSkip to conversation

ASoC: fsl: imx-hdmi: Fix an uninitialized return in probe

PATCH New Dan Carpenter 1 participant 1 message Dec 11, 2020

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: fsl: imx-hdmi: Fix an uninitialized return in probe

The "ret" variable should be set to a negative error code but currently it returns uninitialized stack data.

Fixes 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver")
---
 sound/soc/fsl/imx-hdmi.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/fsl/imx-hdmi.c +1 -0
index 2c2a76a71940..ede4a9ad1054 100644
@@ -164,6 +164,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
 
 	if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
 		dev_err(&pdev->dev, "Invalid HDMI DAI link\n");
+		ret = -EINVAL;
 		goto fail;
 	}
 
Signature · 1 line
2.29.2