media: atomisp: Fix use after free in atomisp_alloc_css_stat_bufs()

PATCH New Dan Carpenter 1 participant 1 message Dec 14, 2020

Subsystems (5)

Media (V4L/DVB) Staging Kernel janitors Intel MID (Mobile Internet Device) platform +1 more subsystems

lore

Share & tools

lore

Dan Carpenter

author

2020-12-14 11:53 UTC #0 lore raw

PATCH 1/1 media: atomisp: Fix use after free in atomisp_alloc_css_stat_bufs()

The "s3a_buf" is freed along with all the other items on the "asd->s3a_stats" list. It leads to a double free and a use after free.

Fixes ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/staging/media/atomisp/pci/atomisp_ioctl.c +1 -3

index 2ae50decfc8b..9da82855552d 100644
@@ -948,10 +948,8 @@ int atomisp_alloc_css_stat_bufs(struct atomisp_sub_device *asd,
 		dev_dbg(isp->dev, "allocating %d dis buffers\n", count);
 		while (count--) {
 			dis_buf = kzalloc(sizeof(struct atomisp_dis_buf), GFP_KERNEL);
-			if (!dis_buf) {
-				kfree(s3a_buf);
+			if (!dis_buf)
 				goto error;
-			}
 			if (atomisp_css_allocate_stat_buffers(
 				asd, stream_id, NULL, dis_buf, NULL)) {
 				kfree(dis_buf);

Signature · 1 line

2.29.2