Input: da7280 - fix missing error test
Subsystems (3)
Dmitry Torokhov
maintainerPATCH 1/1 Input: da7280 - fix missing error test
An "if" testing for error condition has accidentally been dropped from the code.
Reported-by kernel test robot <[email protected]>
Fixes cd3f609823a5 ("Input: new da7280 haptic driver")
Signed-off-by Dmitry Torokhov <[email protected]>
--- drivers/input/misc/da7280.c | 1 + 1 file changed, 1 insertion(+)
drivers/input/misc/da7280.c +1 -0
@@ -863,6 +863,7 @@ static void da7280_parse_properties(struct device *dev, gpi_str3[7 ] ='0' + i; haptics->gpi_ctl[i].polarity =0 ; error =device_property_read_string (dev, gpi_str3, &str); +if (!error) haptics->gpi_ctl[i].polarity =da7280_haptic_of_gpi_pol_str (dev, str); }
Signature · 5 lines
2.29.2.684.gfbc64c5ab5-goog -- Dmitry
Quoted 6 lines · Dmitry Torokhov
An "if" testing for error condition has accidentally been dropped from the code.
Reported-by kernel test robot <[email protected]>Fixes cd3f609823a5 ("Input: new da7280 haptic driver")Signed-off-by Dmitry Torokhov <[email protected]>---
Many thanks for your help.
Reviewed-by Roy Im <[email protected]>