test13-pre4-ac2 - part of diff fails
Quoted 8 lines · On 23-Dec-2000 Daniel Stone wrote:
Quoted 8 lines
Quoted 8 lines
patching file
arch/i386/kernel/smp.c
Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] y
Hunk #1 FAILED at 278.
Hunk #2 succeeded at 511 (offset 9 lines).
1 out of 2 hunks FAILED -- saving rejects to filearch/i386/kernel/smp.c.rej
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Works fine if I reverse it and then put it back in. ?
Its a bug in my patch - get 13pre4ac2 ..
Um.
Subject: Re: test13-pre4-ac2 - part of diff fails
It's _IN_ 13-4ac2.
I applied test13-pre4-ac2 here, and it applied cleanly. Are you applying it to a clean tree? Are your using
patch v2.5.4 ? (that's the version I have)
FWIW, I was getting smp.c patch failures (well, it said the patch was previously applied) along with a bunch of IPTables stuff -- that was a couple of -ac's ago.
AC1 and AC2 applied cleanly, tho AC1 wouldnt compile uniprocessor/no-quotas unless you added a #include <linux/smp_lock.h> to fs/ext2/balloc.c (i.e. it left some hanging refs to lock_kernel and unlock_kernel in fs.o, and I think there was also
one in the UDF module. It's fixed in -ac2.
--
Mark Orr
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
whats happening
In some parts of the kernel code I find expression like
len = (len + ~PAGE_MASK) & PAGE_MASK ;
Whats happening to len?
~sourav
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/
Re: whats happening
Quoted 5 lines · Sourav Sen
In some parts of the kernel code I find expression like
len = (len + ~PAGE_MASK) &
PAGE_MASK;Whats happening to len?
It's being aligned properly.
if you have a continuous array of objects that are each 8 bytes, you create a mask that's FFFFFFF8, then if len=7, instead of doing an operation on the last byte of the first thing and the first 7 bytes of the second, the above expression will add 7, making len 14, then normalize it to the last valid object address, 8. And if you start with a valid address, you get that same address back.
justin
Signature · 7 lines
To summon a demon you must first know its name. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] Please read the FAQ at http://www.tux.org/lkml/
Quoted 14 lines · On 23-Dec-2000 Daniel Stone wrote:
Quoted 12 lines
Quoted 11 lines
Quoted 9 lines
patching file
arch/i386/kernel/smp.c
Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] y
Hunk #1 FAILED at 278.
Hunk #2 succeeded at 511 (offset 9 lines).
1 out of 2 hunks FAILED -- saving rejects to filearch/i386/kernel/smp.c.rejWorks fine if I reverse it and then put it back in. ?
Its a bug in my patch - get 13pre4ac2 ..
Quoted 7 lines
Quoted 3 lines
Um.
Subject: Re: test13-pre4-ac2 - part of diff fails
It's _IN_ 13-4ac2.I applied test13-pre4-ac2 here, and it applied cleanly. Are you applying it to a clean tree? Are your using
patch v2.5.4 ? (that's the version I have)
linux-2.4.0-test12 + reiserfs + test13-pre4 + reiserfs makefile fix (only changes fs/reiserfs/Makefile) + netfilter patch-o-matic stuff (only touches net/ipv4/netfilter) + test13-pre4-ac2.
also seen on just linux-2.4.0-test12 + test13-pre4 + test13-pre4-ac2.
Quoted 3 lines
FWIW, I was getting
smp.cpatch failures (well, it said the patch was previously applied) along with a bunch of IPTables stuff -- that was a couple of -ac's ago.
same here, just forgot to report it.
Quoted 6 lines
AC1 and AC2 applied cleanly, tho AC1 wouldnt compile uniprocessor/no-quotas unless you added a #include <
linux/smp_lock.h> tofs/ext2/balloc.c(i.e. it left some hanging refs tolock_kernelandunlock_kernelin fs.o, and I think there was also
one in the UDF module. It's fixed in -ac2.
ac1 came out while I was asleep, and I woke up to ac2 being released.
d
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/