Skip to contentSkip to conversation

ARM: spitz: include header defining input event codes

PATCH In review Dmitry Torokhov 2 participants 2 messages Feb 21, 2023 – Feb 23, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: spitz: include header defining input event codes

The board file for Sharp SL-Cxx00 Series of PDAs uses various KEY_* defines, but does not include the relevant header directly and instead relies on other headers to include it indirectly. With the upcoming cleanup of matrix_keypad.h this indirection is now broken and we should include the relevant header directly.

Reported: Guenter Roeck <[email protected]>

---

If there are no objections to this patch I would like to get it through my tree. Thanks!

 arch/arm/mach-pxa/spitz.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-pxa/spitz.c +1 -0
index 9964729cd428..75634ef6688d 100644
@@ -25,6 +25,7 @@
 #include <linux/spi/pxa2xx_spi.h>
 #include <linux/mtd/sharpsl.h>
 #include <linux/mtd/physmap.h>
+#include <linux/input-event-codes.h>
 #include <linux/input/matrix_keypad.h>
 #include <linux/regulator/machine.h>
 #include <linux/io.h>
Signature · 5 lines
2.39.2.637.g21b0678d19-goog


-- 
Dmitry
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Dmitry Torokhov

The board file for Sharp SL-Cxx00 Series of PDAs uses various KEY_* defines, but does not include the relevant header directly and instead relies on other headers to include it indirectly. With the upcoming cleanup of matrix_keypad.h this indirection is now broken and we should include the relevant header directly.

Quoted 6 lines

Reported: Guenter Roeck <[email protected]>

---

If there are no objections to this patch I would like to get it through my tree. Thanks!

Yes, that's fine,