Skip to contentSkip to conversation

spi: spidev: Fix double unlock in spidev_sync()

PATCH In review Dan Carpenter 2 participants 2 messages Feb 6, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: spidev: Fix double unlock in spidev_sync()

This unlocks twice due to a merge issue.

Fixes 35bba23e6732 ("Merge remote-tracking branch 'spi/for-6.2' into spi-6.2")
---
 drivers/spi/spidev.c | 2 --
 1 file changed, 2 deletions(-)
drivers/spi/spidev.c +0 -2
index f836567c631b..5a038c667401 100644
@@ -115,8 +115,6 @@ spidev_sync(struct spidev_data *spidev, struct spi_message *message)
 	else
 		status = spidev_sync_unlocked(spi, message);
 
-	mutex_unlock(&spidev->spi_lock);
-
 	mutex_unlock(&spidev->spi_lock);
 	return status;
 }
Signature · 1 line
2.35.1
maintainer
#1 lore raw
Quoted 3 lines · Dan Carpenter

This unlocks twice due to a merge issue.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spidev: Fix double unlock in spidev_sync()

      commit: 941811980df00161fe639c252dabe6488875887c

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark