spi: bcmbca-hsspi: Fix error code in probe() function
Subsystems (4)
PATCH 1/1 spi: bcmbca-hsspi: Fix error code in probe() function
This code accidentally returns success instead of a negative error code.
--- drivers/spi/spi-bcmbca-hsspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/spi/spi-bcmbca-hsspi.c +2 -1
@@ -546,7 +546,8 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev)pm_runtime_enable (&pdev->dev); -if (sysfs_create_group (&pdev->dev.kobj, &bcmbca_hsspi_group)) { + ret =sysfs_create_group (&pdev->dev.kobj, &bcmbca_hsspi_group); +if (ret) {dev_err (&pdev->dev,"couldn't register sysfs group\n" ); goto out_pm_disable; }
Signature · 1 line
2.35.1
Quoted 4 lines · Dan Carpenter
This code accidentally returns success instead of a negative error code.
Fixes a38a2233f23b ("spi: bcmbca-hsspi: Add driver for newer HSSPI controller")Signed-off-by Dan Carpenter <[email protected]>
Signature · 1 line
Florian
Quoted 14 lines · Dan Carpenter
This code accidentally returns success instead of a negative error code.
Fixes a38a2233f23b ("spi: bcmbca-hsspi: Add driver for newer HSSPI controller")Signed-off-by Dan Carpenter <[email protected]>--- drivers/spi/spi-bcmbca-hsspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/spi/spi-bcmbca-hsspi.c +0
-0
drivers/spi/spi-bcmbca-hsspi.c static int bcmbca_hsspi_probe(struct platform_device *pdev) · line 553
Quoted 9 lines
drivers/spi/spi-bcmbca-hsspi.c +2
-1@@ -546,7 +546,8 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev)pm_runtime_enable (&pdev->dev); -if (sysfs_create_group (&pdev->dev.kobj, &bcmbca_hsspi_group)) { + ret =sysfs_create_group (&pdev->dev.kobj, &bcmbca_hsspi_group); +if (ret) {dev_err (&pdev->dev,"couldn't register sysfs group\n" ); goto out_pm_disable; }
Thanks Dan for fixing both drivers!
Mark Brown
maintainerQuoted 3 lines · Dan Carpenter
This code accidentally returns success instead of a negative error code.
Applied to
broonie/spi.git for-next
Thanks!
[1/1] spi: bcmbca-hsspi: Fix error code in probe() function
commit: 0696532e12524855fa8044590d374079f271f216
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark