HID: roccat: Convert snprintf() to sysfs_emit()
Subsystems (2)
PATCH 3/3 HID: roccat: Convert snprintf() to sysfs_emit()
Coccinnelle reports a warning
Warning: Use scnprintf or sprintf
Following the advice on kernel documentation
https://www.kernel.org/doc/html/latest/filesystems/sysfs.html
For show(device *...) functions we should only use sysfs_emit() or sysfs_emit_at() especially when formatting the value to be returned to user space.
Convert snprintf() to sysfs_emit()
Signed-off-by Jules Irenge <[email protected]>
--- drivers/hid/hid-roccat-koneplus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hid/hid-roccat-koneplus.c +2 -2
@@ -244,7 +244,7 @@ static ssize_t koneplus_sysfs_show_actual_profile(struct device *dev, {struct koneplus_device *koneplus =hid_get_drvdata (dev_get_drvdata (dev->parent->parent)); -return snprintf (buf,PAGE_SIZE ,"%d\n" , koneplus->actual_profile); +return sysfs_emit (buf,"%d\n" , koneplus->actual_profile); } static ssize_t koneplus_sysfs_set_actual_profile(struct device *dev,
@@ -311,7 +311,7 @@ static ssize_t koneplus_sysfs_show_firmware_version(struct device *dev, &info, KONEPLUS_SIZE_INFO);mutex_unlock (&koneplus->koneplus_lock); -return snprintf (buf,PAGE_SIZE ,"%d\n" , info.firmware_version); +return sysfs_emit (buf,"%d\n" , info.firmware_version); } static DEVICE_ATTR(firmware_version, 0440, koneplus_sysfs_show_firmware_version, NULL);
Signature · 1 line
2.37.3