Skip to contentSkip to conversation

sunhme: Uninitialized variable in happy_meal_init()

PATCH Superseded Dan Carpenter 2 participants 2 messages Oct 14, 2022

Subsystems (4)
Networking Network drivers Kernel janitors Sun happy meal Ethernet driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 sunhme: Uninitialized variable in happy_meal_init()

The "burst" string is only initialized for CONFIG_SPARC.

Fixes 24cddbc3ef11 ("sunhme: Combine continued messages")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/net/ethernet/sun/sunhme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/sun/sunhme.c +1 -1
index 62deed210a95..efaa6a8eadec 100644
@@ -1328,7 +1328,7 @@ static int happy_meal_init(struct happy_meal *hp)
 	void __iomem *erxregs      = hp->erxregs;
 	void __iomem *bregs        = hp->bigmacregs;
 	void __iomem *tregs        = hp->tcvregs;
-	const char *bursts;
+	const char *bursts = "";
 	u32 regtmp, rxcfg;
 
 	/* If auto-negotiation timer is running, kill it. */
Signature · 1 line
2.35.1
maintainer
#1 lore raw
Quoted 13 lines · Dan Carpenter

The "burst" string is only initialized for CONFIG_SPARC.

Fixes 24cddbc3ef11 ("sunhme: Combine continued messages")
Signed-off-by Dan Carpenter <[email protected]>
---
  drivers/net/ethernet/sun/sunhme.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/sun/sunhme.c +0 -0
index 62deed210a95..efaa6a8eadec 100644

drivers/net/ethernet/sun/sunhme.c static int happy_meal_init(struct happy_meal *hp) · line 1334

Quoted 8 lines
drivers/net/ethernet/sun/sunhme.c +1 -1
@@ -1328,7 +1328,7 @@ static int happy_meal_init(struct happy_meal *hp)
  	void __iomem *erxregs      = hp->erxregs;
  	void __iomem *bregs        = hp->bigmacregs;
  	void __iomem *tregs        = hp->tcvregs;
-	const char *bursts;
+	const char *bursts = "";
  	u32 regtmp, rxcfg;
 
  	/* If auto-negotiation timer is running, kill it. */

This should be "64" to match the value used by PCI.

--Sean