x86/paravirt: Fix a !PARAVIRT build warning
Subsystems (3)
Borislav Petkov
maintainerPATCH 1/1 x86/paravirt: Fix a !PARAVIRT build warning
Hi,
this goes ontop of x86/core as the issue is caused by one of the includes in callthunks.c there.
Thx.
---
From: Borislav Petkov <[email protected]>
Fix
./include/trace/events/xen.h:28:31: warning: ‘enum paravirt_lazy_mode’ \
declared inside parameter list will not be visible outside of this definition or declaration
which turns into a build error:
./include/trace/events/xen.h:28:50: error: parameter 1 (‘mode’) has incomplete type
28 | TP_PROTO(enum paravirt_lazy_mode mode), \
due to enum paravirt_lazy_mode being visible only under CONFIG_PARAVIRT. Just pull it up where it is unconditionally visible.
--- arch/x86/include/asm/paravirt_types.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
arch/x86/include/asm/paravirt_types.h +7 -7
@@ -9,6 +9,13 @@ struct paravirt_patch_site {u8 type;/* type of this instruction */ u8 len; /* length of original instruction */ }; + +/* Lazy mode for batching updates / context switch */ +enum paravirt_lazy_mode { +PARAVIRT_LAZY_NONE , +PARAVIRT_LAZY_MMU , +PARAVIRT_LAZY_CPU , +};#endif #ifdef CONFIG_PARAVIRT
@@ -582,13 +589,6 @@ int paravirt_disable_iospace(void);__PVOP_VCALL (op,PVOP_CALL_ARG1 (arg1),PVOP_CALL_ARG2 (arg2), \ PVOP_CALL_ARG3(arg3), PVOP_CALL_ARG4(arg4)) -/* Lazy mode for batching updates / context switch */ -enum paravirt_lazy_mode { -PARAVIRT_LAZY_NONE , -PARAVIRT_LAZY_MMU , -PARAVIRT_LAZY_CPU , -}; -enum paravirt_lazy_mode paravirt_get_lazy_mode (void );void paravirt_start_context_switch (struct task_struct *prev);void paravirt_end_context_switch (struct task_struct *next);
Signature · 8 lines
2.35.1
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteThe following commit has been merged into the x86/core branch of tip:
The following commit has been merged into the x86/core branch of tip:
Commit-ID: dbf53a29b28b277fa952a000245b558536c6bdd7 Gitweb: https://git.kernel.org/tip/dbf53a29b28b277fa952a000245b558536c6bdd7 Author: Borislav Petkov <[email protected]> AuthorDate: Wed, 19 Oct 2022 18:59:45 +02:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Thu, 20 Oct 2022 16:00:59 +02:00
x86/paravirt: Fix a !PARAVIRT build warning
Fix
./include/trace/events/xen.h:28:31: warning: ‘enum paravirt_lazy_mode’ \
declared inside parameter list will not be visible outside of this definition or declaration
which turns into a build error:
./include/trace/events/xen.h:28:50: error: parameter 1 (‘mode’) has incomplete type
28 | TP_PROTO(enum paravirt_lazy_mode mode), \
due to enum paravirt_lazy_mode being visible only under CONFIG_PARAVIRT. Just pull it up where it is unconditionally visible.
--- arch/x86/include/asm/paravirt_types.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
arch/x86/include/asm/paravirt_types.h +7 -7
@@ -9,6 +9,13 @@ struct paravirt_patch_site {u8 type;/* type of this instruction */ u8 len; /* length of original instruction */ }; + +/* Lazy mode for batching updates / context switch */ +enum paravirt_lazy_mode { +PARAVIRT_LAZY_NONE , +PARAVIRT_LAZY_MMU , +PARAVIRT_LAZY_CPU , +};#endif #ifdef CONFIG_PARAVIRT
@@ -582,13 +589,6 @@ int paravirt_disable_iospace(void);__PVOP_VCALL (op,PVOP_CALL_ARG1 (arg1),PVOP_CALL_ARG2 (arg2), \ PVOP_CALL_ARG3(arg3), PVOP_CALL_ARG4(arg4)) -/* Lazy mode for batching updates / context switch */ -enum paravirt_lazy_mode { -PARAVIRT_LAZY_NONE , -PARAVIRT_LAZY_MMU , -PARAVIRT_LAZY_CPU , -}; -enum paravirt_lazy_mode paravirt_get_lazy_mode (void );void paravirt_start_context_switch (struct task_struct *prev);void paravirt_end_context_switch (struct task_struct *next);