RDMA/qedr: clean up work queue on failure in qedr_alloc_resources()
Subsystems (3)
PATCH 1/1 RDMA/qedr: clean up work queue on failure in qedr_alloc_resources()
Add a check for if create_singlethread_workqueue() fails and also destroy the work queue on failure paths.
Fixes e411e0587e0d ("RDMA/qedr: Add iWARP connection management functions")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/infiniband/hw/qedr/main.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/infiniband/hw/qedr/main.c +8 -1
@@ -344,6 +344,10 @@ static int qedr_alloc_resources(struct qedr_dev *dev)if (IS_IWARP (dev)) {xa_init (&dev->qps); dev->iwarp_wq =create_singlethread_workqueue ("qedr_iwarpq" ); +if (!dev->iwarp_wq) { + rc = -ENOMEM ; + goto err1; + } }/* Allocate Status blocks for CNQ */
@@ -351,7 +355,7 @@ static int qedr_alloc_resources(struct qedr_dev *dev) GFP_KERNEL);if (!dev->sb_array) { rc = -ENOMEM ; - goto err1; + goto err_destroy_wq; } dev->cnq_array = kcalloc(dev->num_cnq,
@@ -402,6 +406,9 @@ static int qedr_alloc_resources(struct qedr_dev *dev)kfree (dev->cnq_array); err2:kfree (dev->sb_array); +err_destroy_wq: +if (IS_IWARP (dev)) +destroy_workqueue (dev->iwarp_wq); err1:kfree (dev->sgid_tbl);return rc;
Signature · 1 line
2.35.1
Leon Romanovsky
AppliedQuoted 4 lines · Dan Carpenter
Add a check for if
create_singlethread_workqueue()fails and also destroy the work queue on failure paths.
Applied, thanks!
[1/1] RDMA/qedr: clean up work queue on failure in qedr_alloc_resources()
https://git.kernel.org/rdma/rdma/c/569ab362c3073a
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>