distro/pxeboot: Handle prompt variable
PATCH 1/1 distro/pxeboot: Handle prompt variable
Regarding the documentation found here:
https://github.com/u-boot/u-boot/blob/master/common/menu.c#L347
If both timeout and prompt is set to 0 the default entry shall be booted immediately. However the current behaviour is that the prompt is shown (tested with distroboot) until the user selects an entry (no timeout).
This change implements a behaviour as documented. It was tested with distroboot.
--- boot/pxe_utils.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
boot/pxe_utils.c +4 -1
@@ -1359,7 +1359,10 @@ static int parse_pxefile_top(struct pxe_context *ctx, char *p, unsigned long basbreak ;case T_PROMPT : -eol_or_eof (&p); + err =parse_integer (&p, &cfg->prompt); +// Do not fail if prompt configuration is undefined +if (err <0 ) +eol_or_eof (&p);break ;case T_EOL :
Signature · 1 line
2.35.1
Quoted 9 lines · Manuel Traut
Regarding the documentation found here:
https://github.com/u-boot/u-boot/blob/master/common/menu.c#L347If both timeout and prompt is set to 0 the default entry shall be booted immediately. However the current behaviour is that the prompt is shown (tested with distroboot) until the user selects an entry (no timeout).
Quoted 7 lines
This change implements a behaviour as documented. It was tested with distroboot.
Signed-off-by Manuel Traut <[email protected]>--- boot/pxe_utils.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Traut Manuel LCPF-CH
Reviewed-by Simon GlassCan this be picked for next?
-----Ursprüngliche Nachricht-----
Von: Simon Glass <[email protected]>
Gesendet: Sonntag, 27. November 2022 15:36
An: Traut Manuel LCPF-CH <[email protected]>
Cc: [email protected]; [email protected]
Betreff: Re: EXTERNAL - [PATCH] distro/pxeboot: Handle prompt variable
Quoted 9 lines · Manuel Traut
Regarding the documentation found here:
https://github.com/u-boot/u-boot/blob/master/common/menu.c#L347If both timeout and prompt is set to 0 the default entry shall be booted immediately. However the current behaviour is that the prompt is shown (tested with distroboot) until the user selects an entry (no timeout).
Quoted 7 lines
This change implements a behaviour as documented. It was tested with distroboot.
Signed-off-by Manuel Traut <[email protected]>--- boot/pxe_utils.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 8 lines · Manuel Traut
Regarding the documentation found here:
https://github.com/u-boot/u-boot/blob/master/common/menu.c#L347If both timeout and prompt is set to 0 the default entry shall be booted immediately. However the current behaviour is that the prompt is shown (tested with distroboot) until the user selects an entry (no timeout).
Quoted 6 lines
This change implements a behaviour as documented. It was tested with distroboot.
Signed-off-by Manuel Traut <[email protected]>Reviewed-by Simon Glass <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/next, thanks!
Signature · 1 line
Tom