Skip to contentSkip to conversation

KVM: selftests: Fixes for 6.2

GIT PULL Sean Christopherson 2 participants 2 messages Dec 1, 2022 – Dec 2, 2022 KVM

lore
Share & tools
lore

Sean Christopherson

author reviewer
#0 lore raw

Please pull selftests fixes for 6.2. Most of these are fixes for things that are sitting in kvm/queue.

Thanks!

The following changes since commit df0bb47baa95aad133820b149851d5b94cbc6790:

KVM: x86: fix uninitialized variable use on KVM_REQ_TRIPLE_FAULT (2022-11-30 11:50:39 -0500)

are available in the Git repository at:

https://github.com/kvm-x86/linux.git tags/kvm-selftests-6.2-2

for you to fetch changes up to 0c3265235fc17e78773025ed0ddc7c0324b6ed89:

KVM: selftests: Define and use a custom static assert in lib headers (2022-12-01 15:31:46 -0800)

----------------------------------------------------------------
KVM selftests fixes for 6.2

- Fix an inverted check in the access tracking perf test, and restore support for asserting that there aren't too many idle pages when running on bare metal.

- Fix an ordering issue in the AMX test introduced by recent conversions to use kvm_cpu_has(), and harden the code to guard against similar bugs in the future. Anything that tiggers caching of KVM's supported CPUID, kvm_cpu_has() in this case, effectively hides opt-in XSAVE features if the caching occurs before the test opts in via prctl().

- Fix build errors that occur in certain setups (unsure exactly what is unique about the problematic setup) due to glibc overriding static_assert() to a variant that requires a custom message.

----------------------------------------------------------------
Lei Wang (1):
KVM: selftests: Move XFD CPUID checking out of __vm_xsave_require_permission()

Sean Christopherson (6):
KVM: selftests: Fix inverted "warning" in access tracking perf test
KVM: selftests: Restore assert for non-nested VMs in access tracking test
KVM: selftests: Move __vm_xsave_require_permission() below CPUID helpers
KVM: selftests: Disallow "get supported CPUID" before REQ_XCOMP_GUEST_PERM
KVM: selftests: Do kvm_cpu_has() checks before creating VM+vCPU
KVM: selftests: Define and use a custom static assert in lib headers

 tools/testing/selftests/kvm/access_tracking_perf_test.c | 22 ++++++++++++++--------
 tools/testing/selftests/kvm/include/kvm_util_base.h     | 14 +++++++++++++-
 tools/testing/selftests/kvm/include/x86_64/processor.h  | 23 ++++++++++++-----------
 tools/testing/selftests/kvm/lib/x86_64/processor.c      | 84 ++++++++++++++++++++++++++++++++++++++++++++----------------------------------------
 tools/testing/selftests/kvm/x86_64/amx_test.c           | 11 ++++++++---
 5 files changed, 91 insertions(+), 63 deletions(-)
maintainer
#1 lore raw
Quoted 10 lines · Sean Christopherson

Please pull selftests fixes for 6.2. Most of these are fixes for things that are sitting in kvm/queue.

Thanks!

The following changes since commit df0bb47baa95aad133820b149851d5b94cbc6790:

   KVM: x86: fix uninitialized variable use on KVM_REQ_TRIPLE_FAULT (2022-11-30 11:50:39 -0500)
Quoted 7 lines

are available in the Git repository at:

   https://github.com/kvm-x86/linux.git tags/kvm-selftests-6.2-2

for you to fetch changes up to 0c3265235fc17e78773025ed0ddc7c0324b6ed89:

KVM: selftests: Define and use a custom static assert in lib headers (2022-12-01 15:31:46 -0800)

Pulled, thanks.

Paolo

Quoted 36 lines

----------------------------------------------------------------
KVM selftests fixes for 6.2

- Fix an inverted check in the access tracking perf test, and restore support for asserting that there aren't too many idle pages when running on bare metal.

- Fix an ordering issue in the AMX test introduced by recent conversions to use kvm_cpu_has(), and harden the code to guard against similar bugs in the future. Anything that tiggers caching of KVM's supported CPUID, kvm_cpu_has() in this case, effectively hides opt-in XSAVE features if the caching occurs before the test opts in via prctl().

- Fix build errors that occur in certain setups (unsure exactly what is unique about the problematic setup) due to glibc overriding static_assert() to a variant that requires a custom message.

----------------------------------------------------------------
Lei Wang (1):
KVM: selftests: Move XFD CPUID checking out of __vm_xsave_require_permission()

Sean Christopherson (6):
KVM: selftests: Fix inverted "warning" in access tracking perf test
KVM: selftests: Restore assert for non-nested VMs in access tracking test
KVM: selftests: Move __vm_xsave_require_permission() below CPUID helpers
KVM: selftests: Disallow "get supported CPUID" before REQ_XCOMP_GUEST_PERM
KVM: selftests: Do kvm_cpu_has() checks before creating VM+vCPU
KVM: selftests: Define and use a custom static assert in lib headers

  tools/testing/selftests/kvm/access_tracking_perf_test.c | 22 ++++++++++++++--------
  tools/testing/selftests/kvm/include/kvm_util_base.h     | 14 +++++++++++++-
  tools/testing/selftests/kvm/include/x86_64/processor.h  | 23 ++++++++++++-----------
  tools/testing/selftests/kvm/lib/x86_64/processor.c      | 84 ++++++++++++++++++++++++++++++++++++++++++++----------------------------------------
  tools/testing/selftests/kvm/x86_64/amx_test.c           | 11 ++++++++---
  5 files changed, 91 insertions(+), 63 deletions(-)