Skip to contentSkip to conversation

MIPS: OCTEON: warn only once if deprecated link status is being used

PATCH Applied Ladislav Michl 3 participants 3 messages Dec 8, 2022 – Dec 9, 2022 MIPS

lore
Share & tools
lore

Ladislav Michl

author
#0 lore raw

PATCH 1/1 MIPS: OCTEON: warn only once if deprecated link status is being used

From: Ladislav Michl <[email protected]>

Avoid flooding kernel log with warnings.

Fixes 2c0756d306c2 ("MIPS: OCTEON: warn if deprecated link status is being used")
Signed-off-by Ladislav Michl <[email protected]>
---
 arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 2 +-
 arch/mips/cavium-octeon/executive/cvmx-helper.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/mips/cavium-octeon/executive/cvmx-helper-board.c +1 -1
index d09d0769f549..0fd9ac76eb74 100644
@@ -211,7 +211,7 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)
 {
 	union cvmx_helper_link_info result;
 
-	WARN(!octeon_is_simulation(),
+	WARN_ONCE(!octeon_is_simulation(),
 	     "Using deprecated link status - please update your DT");
 
 	/* Unless we fix it later, all links are defaulted to down */
arch/mips/cavium-octeon/executive/cvmx-helper.c +1 -1
index 6f49fd9be1f3..9abfc4bf9bd8 100644
@@ -1096,7 +1096,7 @@ union cvmx_helper_link_info cvmx_helper_link_get(int ipd_port)
 		if (index == 0)
 			result = __cvmx_helper_rgmii_link_get(ipd_port);
 		else {
-			WARN(1, "Using deprecated link status - please update your DT");
+			WARN_ONCE(1, "Using deprecated link status - please update your DT");
 			result.s.full_duplex = 1;
 			result.s.link_up = 1;
 			result.s.speed = 1000;
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Ladislav Michl

From: Ladislav Michl <[email protected]>

Avoid flooding kernel log with warnings.

Fixes 2c0756d306c2 ("MIPS: OCTEON: warn if deprecated link status is being used")
Signed-off-by Ladislav Michl <[email protected]>
---
  arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 2 +-
  arch/mips/cavium-octeon/executive/cvmx-helper.c       | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
maintainer Applied
#2 lore raw
In reply to Ladislav Michl
Quoted 10 lines · Ladislav Michl

From: Ladislav Michl <[email protected]>

Avoid flooding kernel log with warnings.

Fixes 2c0756d306c2 ("MIPS: OCTEON: warn if deprecated link status is being used")
Signed-off-by Ladislav Michl <[email protected]>
---
 arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 2 +-
 arch/mips/cavium-octeon/executive/cvmx-helper.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]