Skip to contentSkip to conversation

Reduce number of concurrent KGDB_MAX_BREAKPOINTS

PATCH New Helge Deller 1 participant 1 message Dec 20, 2022 1 message not in the archive KGDB / KDB /debug_core

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 Reduce number of concurrent KGDB_MAX_BREAKPOINTS

In reply to a message not in the archive

------- Forwarded Message --------
Subject: [PATCH] Reduce number of concurrent KGDB_MAX_BREAKPOINTS
Date: Mon, 19 Dec 2022 23:11:07 +0100
From: Helge Deller <[email protected]>
To: Jason Wessel <[email protected]>, Daniel Thompson <[email protected]>, Douglas Anderson <[email protected]>, [email protected]

On my 32-bit machine, with BREAK_INSTR_SIZE=4 the kgdb_break[] structure allocates 16000 bytes of static kernel memory, which is - by default - to be able to handle up to 1000 concurrent kgdb breakpoints. I might be wrong, but I doubt that in real life someone really needs that many breakpoints, so I suggest to reduce the number of possible kgdb breakpoints and thus reduce the memory footprint of kgdb_break[].

include/linux/kgdb.h +1 -1
index 258cdde8d356..fab81c4f007e 100644
@@ -95,7 +95,7 @@ extern char *dbg_get_reg(int regno, void *mem, struct pt_regs *regs);
 extern int dbg_set_reg(int regno, void *mem, struct pt_regs *regs);
 #endif
 #ifndef KGDB_MAX_BREAKPOINTS
-# define KGDB_MAX_BREAKPOINTS	1000
+# define KGDB_MAX_BREAKPOINTS	40
 #endif
 
 #define KGDB_HW_BREAKPOINT	1