scsi: fnic: Use sysfs_emit in show function callsbacks
Subsystems (2)
PATCH 1/1 scsi: fnic: Use sysfs_emit in show function callsbacks
According to Documentation/filesystems/sysfs.rst, the show() callback function of kobject attributes should strictly use sysfs_emit() instead of sprintf() family functions. So, make this change.
Issue identified using the coccinelle device_attr_show.cocci script.
Signed-off-by Deepak R Varma <[email protected]>
--- drivers/scsi/fnic/fnic_attrs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/fnic/fnic_attrs.c +3 -3
@@ -14,13 +14,13 @@ static ssize_t fnic_show_state(struct device *dev,struct fc_lport *lp =shost_priv (class_to_shost (dev));struct fnic *fnic =lport_priv (lp); -return snprintf (buf,PAGE_SIZE ,"%s\n" , fnic_state_str[fnic->state]); +return sysfs_emit (buf,"%s\n" , fnic_state_str[fnic->state]); }static ssize_t fnic_show_drv_version (struct device *dev,struct device_attribute *attr,char *buf) { -return snprintf (buf,PAGE_SIZE ,"%s\n" ,DRV_VERSION ); +return sysfs_emit (buf,"%s\n" ,DRV_VERSION ); } static ssize_t fnic_show_link_state(struct device *dev,
@@ -28,7 +28,7 @@ static ssize_t fnic_show_link_state(struct device *dev, {struct fc_lport *lp =shost_priv (class_to_shost (dev)); -return snprintf (buf,PAGE_SIZE ,"%s\n" , (lp->link_up) +return sysfs_emit (buf,"%s\n" , (lp->link_up) ?"Link Up" :"Link Down" ); }
--
2.34.1