Skip to contentSkip to conversation

coccinelle: api/atomic_as_refcounter: include message type in output

PATCH Superseded Deepak R Varma 2 participants 3 messages Dec 25, 2022 – Dec 26, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 coccinelle: api/atomic_as_refcounter: include message type in output

A common practice is to grep for "WARNING" or "ERROR" text in the report output from a coccinelle semantic patch script. So, include the test "WARNING: " in the report output generated by the semantic patch for desired filtering of the output. Also improves the readability of the output. Here is an example of the old and new outputs reported:

xyz_file.c:131:39-40: atomic_add_unless xyz_file.c:131:39-40: WARNING: atomic_add_unless

xyz_file.c:196:6-25: atomic_dec_and_test variation before object free at line 208. xyz_file.c:196:6-25: WARNING: atomic_dec_and_test variation before object free at line 208.

---
 scripts/coccinelle/api/atomic_as_refcounter.cocci | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
scripts/coccinelle/api/atomic_as_refcounter.cocci +4 -4
index e63d52408b86..bbe5b2932933 100644
@@ -55,7 +55,7 @@ identifier fname6 =~ ".*call_rcu.*";
 p1 << r1.p1;
 p2 << r1.p2;
 @@
-msg = "atomic_dec_and_test variation before object free at line %s."
+msg = "WARNING: atomic_dec_and_test variation before object free at line %s."
 coccilib.report.print_report(p1[0], msg % (p2[0].line))
 
 @r4 exists@
@@ -88,7 +88,7 @@ fname@p2(y, ...);
 p1 << r4.p1;
 p2 << r4.p2;
 @@
-msg = "atomic_dec_and_test variation before object free at line %s."
+msg = "WARNING: atomic_dec_and_test variation before object free at line %s."
 coccilib.report.print_report(p1[0], msg % (p2[0].line))
 
 @r2 exists@
@@ -107,7 +107,7 @@ atomic64_add_unless(&(a)->x,-1,1)@p1
 @script:python depends on report@
 p1 << r2.p1;
 @@
-msg = "atomic_add_unless"
+msg = "WARNING: atomic_add_unless"
 coccilib.report.print_report(p1[0], msg)
 
 @r3 exists@
@@ -126,5 +126,5 @@ x = atomic64_add_return@p1(-1, ...);
 @script:python depends on report@
 p1 << r3.p1;
 @@
-msg = "x = atomic_add_return(-1, ...)"
+msg = "WARNING: x = atomic_add_return(-1, ...)"
 coccilib.report.print_report(p1[0], msg)

--
2.34.1

#1 lore raw
Quoted 2 lines

… So, include the test "WARNING: " in the report output …

How do you think about to use the word “text” instead of “test” in the change description?

Regards,
Markus

#2 lore raw
Quoted 6 lines · Markus Elfring
Quoted 2 lines

… So, include the test "WARNING: " in the report output …

How do you think about to use the word “text” instead of “test” in the change description?

Hi Markus,
Thank you for catching that. Just sent v2 with the correction.

./drv

Quoted 4 lines

Regards,
Markus