Skip to contentSkip to conversation

drm/tegra: submit: No need for Null pointer check before kfree

PATCH In review Deepak R Varma 3 participants 13 messages Dec 27, 2022 – Jan 22, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tegra: submit: No need for Null pointer check before kfree

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
 drivers/gpu/drm/tegra/submit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +2 -2
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
 		kfree(job_data->used_mappings);
 	}
 
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data);
+
 put_bo:
 	gather_bo_put(&bo->base);
 unlock:

--
2.34.1

#1 lore raw
Quoted 28 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
  drivers/gpu/drm/tegra/submit.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +2 -3
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
  		kfree(job_data->used_mappings);
  	}
 
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data);
+
  put_bo:
  	gather_bo_put(&bo->base);
  unlock:
--
Quoted 4 lines

2.34.1

It continues to be the case that I think this transform is bad. Same applies to the host1x patch.

Mikko

#2 lore raw
Quoted 21 lines · Mikko Perttunen
Quoted 20 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
  drivers/gpu/drm/tegra/submit.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
  		kfree(job_data->used_mappings);
  	}
 
Quoted 15 lines
Quoted 8 lines
drivers/gpu/drm/tegra/submit.c +2 -3
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data);
+
  put_bo:
  	gather_bo_put(&bo->base);
  unlock:
--
Quoted 4 lines

2.34.1

It continues to be the case that I think this transform is bad. Same applies to the host1x patch.

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is this bad?

Regards,
./drv

Quoted 2 lines

Mikko

#3 lore raw
Quoted 38 lines · Deepak R Varma
Quoted 21 lines · Mikko Perttunen
Quoted 20 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
   drivers/gpu/drm/tegra/submit.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
   		kfree(job_data->used_mappings);
   	}
 
Quoted 15 lines
Quoted 8 lines
drivers/gpu/drm/tegra/submit.c +2 -3
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data);
+
   put_bo:
   	gather_bo_put(&bo->base);
   unlock:
--
Quoted 4 lines

2.34.1

It continues to be the case that I think this transform is bad. Same applies to the host1x patch.

Quoted 11 lines

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is this bad?

Regards,
./drv

Quoted 2 lines

Mikko

Hi,

it gets rid of visual hints on code paths indicating the possible liveness of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Since C's type system doesn't help with tracking these kinds of things, I believe it is important to have these kinds of local contextual cues to help the programmer.

Mikko

#4 lore raw
Quoted 53 lines · Mikko Perttunen
Quoted 38 lines · Deepak R Varma
Quoted 21 lines · Mikko Perttunen
Quoted 20 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
   drivers/gpu/drm/tegra/submit.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
   		kfree(job_data->used_mappings);
   	}
 
Quoted 15 lines
Quoted 8 lines
drivers/gpu/drm/tegra/submit.c +2 -3
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data);
+
   put_bo:
   	gather_bo_put(&bo->base);
   unlock:
--
Quoted 4 lines

2.34.1

It continues to be the case that I think this transform is bad. Same applies to the host1x patch.

Quoted 11 lines

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is this bad?

Regards,
./drv

Quoted 2 lines

Mikko

Hi,

Quoted 8 lines

it gets rid of visual hints on code paths indicating the possible liveness of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Since C's type system doesn't help with tracking these kinds of things, I believe it is important to have these kinds of local contextual cues to help the programmer.

Hello Mikko,
That really helps. Thank you for the detailed explanation. I do have an extended question though. In this context, when we are ready to release the memory, how is it useful to know if it is NULL or not this late in the flow when the scope is about to end?

Thanks again!
./drv

Quoted 2 lines

Mikko

#5 lore raw
Quoted 63 lines · Deepak R Varma
Quoted 53 lines · Mikko Perttunen
Quoted 38 lines · Deepak R Varma
Quoted 21 lines · Mikko Perttunen
Quoted 20 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
    drivers/gpu/drm/tegra/submit.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
    		kfree(job_data->used_mappings);
    	}
 
Quoted 15 lines
Quoted 8 lines
drivers/gpu/drm/tegra/submit.c +2 -3
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data);
+
    put_bo:
    	gather_bo_put(&bo->base);
    unlock:
--
Quoted 4 lines

2.34.1

It continues to be the case that I think this transform is bad. Same applies to the host1x patch.

Quoted 11 lines

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is this bad?

Regards,
./drv

Quoted 2 lines

Mikko

Hi,

Quoted 8 lines

it gets rid of visual hints on code paths indicating the possible liveness of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Since C's type system doesn't help with tracking these kinds of things, I believe it is important to have these kinds of local contextual cues to help the programmer.

Quoted 5 lines

Hello Mikko,
That really helps. Thank you for the detailed explanation. I do have an extended question though. In this context, when we are ready to release the memory, how is it useful to know if it is NULL or not this late in the flow when the scope is about to end?

In the current code it doesn't matter, but if someone went to change this code (for example to add another release step), and we just had 'kfree(job_data)', they would have to remember that kfree works with NULL pointers, and would have to go looking elsewhere in the code to see if it is in fact possible to assume that job_data cannot be NULL here, or not. If they forget about kfree working with NULL pointers, which wouldn't be that surprising since it is almost always only called with non-NULL pointers, they might instead introduce a bug.

In this particular instance it's probably not that bad since immediately above we have another 'if' block that checks if job_data is NULL, which serves as a hint to the programmer; however, as a general principle it stands that having the NULL check here makes it obvious to any reading programmer that they any changes they make have to consider if the pointer is NULL or not.

Quoted 4 lines

Thanks again!
./drv

Thanks!
Mikko

Quoted 7 lines
Quoted 5 lines

Mikko

#6 lore raw
Quoted 30 lines · Mikko Perttunen
Quoted 14 lines · Deepak R Varma
Quoted 4 lines · Mikko Perttunen

On 12/28/22 15:08, Deepak R Varma wrote:

Hi,

Quoted 8 lines

it gets rid of visual hints on code paths indicating the possible liveness of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Since C's type system doesn't help with tracking these kinds of things, I believe it is important to have these kinds of local contextual cues to help the programmer.

Quoted 5 lines

Hello Mikko,
That really helps. Thank you for the detailed explanation. I do have an extended question though. In this context, when we are ready to release the memory, how is it useful to know if it is NULL or not this late in the flow when the scope is about to end?

In the current code it doesn't matter, but if someone went to change this code (for example to add another release step), and we just had 'kfree(job_data)', they would have to remember that kfree works with NULL pointers, and would have to go looking elsewhere in the code to see if it is in fact possible to assume that job_data cannot be NULL here, or not. If they forget about kfree working with NULL pointers, which wouldn't be that surprising since it is almost always only called with non-NULL pointers, they might instead introduce a bug.

Quoted 6 lines

In this particular instance it's probably not that bad since immediately above we have another 'if' block that checks if job_data is NULL, which serves as a hint to the programmer; however, as a general principle it stands that having the NULL check here makes it obvious to any reading programmer that they any changes they make have to consider if the pointer is NULL or not.

Sounds good. Thanks again. Would like to see if other experts have any further guidance on this patch.

Regards,
./drv

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

Mikko

#7 lore raw
In reply to Mikko Perttunen
Quoted 53 lines · Mikko Perttunen
Quoted 38 lines · Deepak R Varma
Quoted 21 lines · Mikko Perttunen
Quoted 20 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
   drivers/gpu/drm/tegra/submit.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
   		kfree(job_data->used_mappings);
   	}
 
Quoted 15 lines
Quoted 8 lines
drivers/gpu/drm/tegra/submit.c +2 -3
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data);
+
   put_bo:
   	gather_bo_put(&bo->base);
   unlock:
--
Quoted 4 lines

2.34.1

It continues to be the case that I think this transform is bad. Same applies to the host1x patch.

Quoted 11 lines

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is this bad?

Regards,
./drv

Quoted 2 lines

Mikko

Hi,

Quoted 8 lines

it gets rid of visual hints on code paths indicating the possible liveness of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Since C's type system doesn't help with tracking these kinds of things, I believe it is important to have these kinds of local contextual cues to help the programmer.

I agree with your point of view. But regarding this particular patch, at least on code base I can see, after free_job_data label job_done can not be NULL. So patch seems to be ok, but maybe changelog need to be different

Regards
Stanislaw

#8 lore raw
Quoted 63 lines · Stanislaw Gruszka
Quoted 53 lines · Mikko Perttunen
Quoted 38 lines · Deepak R Varma
Quoted 21 lines · Mikko Perttunen
Quoted 20 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
    drivers/gpu/drm/tegra/submit.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
    		kfree(job_data->used_mappings);
    	}
 
Quoted 15 lines
Quoted 8 lines
drivers/gpu/drm/tegra/submit.c +2 -3
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data);
+
    put_bo:
    	gather_bo_put(&bo->base);
    unlock:
--
Quoted 4 lines

2.34.1

It continues to be the case that I think this transform is bad. Same applies to the host1x patch.

Quoted 11 lines

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is this bad?

Regards,
./drv

Quoted 2 lines

Mikko

Hi,

Quoted 8 lines

it gets rid of visual hints on code paths indicating the possible liveness of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Since C's type system doesn't help with tracking these kinds of things, I believe it is important to have these kinds of local contextual cues to help the programmer.

Quoted 7 lines

I agree with your point of view. But regarding this particular patch, at least on code base I can see, after free_job_data label job_done can not be NULL. So patch seems to be ok, but maybe changelog need to be different

Regards
Stanislaw

It can be NULL; see:

        job->user_data = job_data;
        job->release = release_job;
        job->timeout = 10000;

        /*
         * job_data is now part of job reference counting, so don't release
         * it from here.
         */
        job_data = NULL;

If we go into free_job_data after this code (which happens if there is no error, or if host1x_job_submit fails), job_data will be NULL.

The memory is instead released in the 'put_job' label; host1x_job_put ends up calling release_job, which does the kfree.

(Yes, it is rather complicated..)

Thanks,
Mikko

#9 lore raw
Quoted 86 lines · Mikko Perttunen
Quoted 64 lines · Stanislaw Gruszka
Quoted 54 lines · Mikko Perttunen
Quoted 39 lines · Deepak R Varma
Quoted 22 lines · Mikko Perttunen
Quoted 21 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
    drivers/gpu/drm/tegra/submit.c | 4 ++--

    1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct 
 drm_device *drm, void *data,
             kfree(job_data->used_mappings);
         }
 
Quoted 15 lines
Quoted 4 lines
drivers/gpu/drm/tegra/submit.c +2 -2
-    if (job_data)
-        kfree(job_data);
+    kfree(job_data);
+
Quoted 8 lines

    put_bo:
        gather_bo_put(&bo->base);
    unlock:

Signature · 1 line
2.34.1

It continues to be the case that I think this transform is bad. Same applies to the host1x patch.

Quoted 11 lines

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is this bad?

Regards,
./drv

Quoted 2 lines

Mikko

Hi,

Quoted 8 lines

it gets rid of visual hints on code paths indicating the possible liveness of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Since C's type system doesn't help with tracking these kinds of things, I believe it is important to have these kinds of local contextual cues to help the programmer.

Quoted 7 lines

I agree with your point of view. But regarding this particular patch, at least on code base I can see, after free_job_data label job_done can not be NULL. So patch seems to be ok, but maybe changelog need to be different

Regards
Stanislaw

It can be NULL; see:

        job->user_data = job_data;
        job->release = release_job;
        job->timeout = 10000;

        /*
         * job_data is now part of job reference counting, so don't
release
         * it from here.
         */
        job_data = NULL;

Quoted 3 lines

If we go into free_job_data after this code (which happens if there is no error, or if host1x_job_submit fails), job_data will be NULL.

The memory is instead released in the 'put_job' label; host1x_job_put ends up calling release_job, which does the kfree.

Well, the refcount is dropped -- it's not necessarily freed immediately, if the job is in execution.

Mikko

Quoted 5 lines

(Yes, it is rather complicated..)

Thanks,
Mikko

#10 lore raw
Quoted 94 lines · Mikko Perttunen
Quoted 93 lines · Mikko Perttunen
Quoted 71 lines · Stanislaw Gruszka
Quoted 64 lines · Mikko Perttunen
Quoted 42 lines · Deepak R Varma
Quoted 24 lines · Mikko Perttunen
Quoted 23 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
    drivers/gpu/drm/tegra/submit.c | 4 ++--

    1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int

tegra_drm_ioctl_channel_submit(struct drm_device
*drm, void *data,
            kfree(job_data->used_mappings);
        }

Quoted 16 lines
Quoted 12 lines

-    if (job_data)
-        kfree(job_data);
+    kfree(job_data);
+
    put_bo:
        gather_bo_put(&bo->base);
    unlock:
--
2.34.1

It continues to be the case that I think this transform is bad. Same applies
to the host1x patch.

Quoted 12 lines

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is
this bad?

Regards,
./drv

Quoted 2 lines

Mikko

Hi,

it gets rid of visual hints on code paths indicating the possible liveness
of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Quoted 5 lines

Since C's type system doesn't help with tracking these kinds of things, I
believe it is important to have these kinds of local contextual cues to help
the programmer.

Quoted 7 lines

I agree with your point of view. But regarding this particular patch, at least on code base I can see, after free_job_data label job_done can not be NULL. So patch seems to be ok, but maybe changelog need to be different

Regards
Stanislaw

It can be NULL; see:

        job->user_data = job_data;
        job->release = release_job;
        job->timeout = 10000;

        /*
         * job_data is now part of job reference counting, so don't
release
         * it from here.
         */
        job_data = NULL;

Quoted 8 lines
Quoted 5 lines

If we go into free_job_data after this code (which happens if there is no error, or if host1x_job_submit fails), job_data will be NULL.

The memory is instead released in the 'put_job' label; host1x_job_put ends up calling release_job, which does the kfree.

Well, the refcount is dropped -- it's not necessarily freed immediately, if the job is in execution.

Thanks Mikko. I Agree. Hence I think there is no change for the program at runtime. The proposed change looks safe to me.

./drv

Quoted 9 lines

Mikko

Quoted 5 lines

(Yes, it is rather complicated..)

Thanks,
Mikko

#11 lore raw
Quoted 98 lines · Deepak R Varma
Quoted 97 lines · Mikko Perttunen
Quoted 96 lines · Mikko Perttunen
Quoted 71 lines · Stanislaw Gruszka
Quoted 64 lines · Mikko Perttunen
Quoted 42 lines · Deepak R Varma
Quoted 24 lines · Mikko Perttunen
Quoted 23 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
    drivers/gpu/drm/tegra/submit.c | 4 ++--

    1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int

tegra_drm_ioctl_channel_submit(struct drm_device
*drm, void *data,
            kfree(job_data->used_mappings);
        }

Quoted 16 lines
Quoted 12 lines

-    if (job_data)
-        kfree(job_data);
+    kfree(job_data);
+
    put_bo:
        gather_bo_put(&bo->base);
    unlock:
--
2.34.1

It continues to be the case that I think this transform is bad. Same applies
to the host1x patch.

Quoted 12 lines

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is
this bad?

Regards,
./drv

Quoted 2 lines

Mikko

Hi,

it gets rid of visual hints on code paths indicating the possible liveness
of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Quoted 5 lines

Since C's type system doesn't help with tracking these kinds of things, I
believe it is important to have these kinds of local contextual cues to help
the programmer.

Quoted 7 lines

I agree with your point of view. But regarding this particular patch, at least on code base I can see, after free_job_data label job_done can not be NULL. So patch seems to be ok, but maybe changelog need to be different

Regards
Stanislaw

It can be NULL; see:

        job->user_data = job_data;
        job->release = release_job;
        job->timeout = 10000;

        /*
         * job_data is now part of job reference counting, so don't
release
         * it from here.
         */
        job_data = NULL;

If we go into free_job_data after this code (which happens if there is no error, or if host1x_job_submit fails), job_data will be NULL.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

The memory is instead released in the 'put_job' label; host1x_job_put ends up calling release_job, which does the kfree.

Well, the refcount is dropped -- it's not necessarily freed immediately, if the job is in execution.

Thanks Mikko. I Agree. Hence I think there is no change for the program at runtime. The proposed change looks safe to me.

Hello,
Requesting any further feedback/comment on this patch proposal.

Thank you,
./drv

Quoted 12 lines

./drv

Quoted 9 lines

Mikko

Quoted 5 lines

(Yes, it is rather complicated..)

Thanks,
Mikko

#12 lore raw
In reply to Mikko Perttunen
Quoted 84 lines · Mikko Perttunen
Quoted 63 lines · Stanislaw Gruszka
Quoted 53 lines · Mikko Perttunen
Quoted 38 lines · Deepak R Varma
Quoted 21 lines · Mikko Perttunen
Quoted 20 lines · Deepak R Varma

kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree().

Issue reported by ifnullfree.cocci Coccinelle semantic patch script.

---
    drivers/gpu/drm/tegra/submit.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/submit.c +0 -0
index 066f88564169..06f836db99d0 100644
@@ -680,8 +680,8 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
    		kfree(job_data->used_mappings);
    	}
 
Quoted 15 lines
Quoted 8 lines
drivers/gpu/drm/tegra/submit.c +2 -3
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data);
+
    put_bo:
    	gather_bo_put(&bo->base);
    unlock:
--
Quoted 4 lines

2.34.1

It continues to be the case that I think this transform is bad. Same applies to the host1x patch.

Quoted 11 lines

Hello Mikko,
Thank you for responding to the patch proposal. Could you please explain why is this bad?

Regards,
./drv

Quoted 2 lines

Mikko

Hi,

Quoted 8 lines

it gets rid of visual hints on code paths indicating the possible liveness of pointer variables. I.e., after the change, whether the pointer can be NULL or not is more difficult to reason about locally, instead requiring more global reasoning which is mentally more taxing.

Since C's type system doesn't help with tracking these kinds of things, I believe it is important to have these kinds of local contextual cues to help the programmer.

Quoted 7 lines

I agree with your point of view. But regarding this particular patch, at least on code base I can see, after free_job_data label job_done can not be NULL. So patch seems to be ok, but maybe changelog need to be different

Regards
Stanislaw

It can be NULL; see:

        job->user_data = job_data;
        job->release = release_job;
        job->timeout = 10000;

        /*
         * job_data is now part of job reference counting, so don't release
         * it from here.
         */
        job_data = NULL;
Quoted 7 lines

If we go into free_job_data after this code (which happens if there is no error, or if host1x_job_submit fails), job_data will be NULL.

The memory is instead released in the 'put_job' label; host1x_job_put ends up calling release_job, which does the kfree.

(Yes, it is rather complicated..)

Ok, then better to keep the check.

Regards
Stanislaw