Skip to contentSkip to conversation

soc: qcom: dcc: Signedness bug in config_reset_write()

PATCH In review Dan Carpenter 3 participants 5 messages Jan 5, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 soc: qcom: dcc: Signedness bug in config_reset_write()

The "ret" variable needs to be signed for the error handling to work.

Fixes 4cbe60cf5ad6 ("soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)")
---
 drivers/soc/qcom/dcc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/qcom/dcc.c +2 -1
index d4101f79cb5d..1e2cbefc1655 100644
@@ -808,8 +808,9 @@ static ssize_t config_reset_write(struct file *filp,
 				  const char __user *user_buf, size_t count,
 				  loff_t *ppos)
 {
-	unsigned int val, ret;
+	unsigned int val;
 	struct dcc_drvdata *drvdata = filp->private_data;
+	int ret;
 
 	ret = kstrtouint_from_user(user_buf, count, 0, &val);
 	if (ret < 0)
Signature · 1 line
2.35.1
#1 lore raw

PATCH 2/2 soc: qcom: dcc: Delete some bogus dead code

It feels very wrong to assign "cfg.sram_offset" to be out of bounds. Fortunately, this is just dead code and can be deleted.

---
 drivers/soc/qcom/dcc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/qcom/dcc.c +1 -3
index 1e2cbefc1655..681d55018e66 100644
@@ -483,10 +483,8 @@ static int dcc_emit_config(struct dcc_drvdata *drvdata, unsigned int curr_list)
 	/* Update ram_cfg and check if the data will overstep */
 	drvdata->ram_cfg = (cfg.sram_offset + total_len) / 4;
 
-	if (cfg.sram_offset + total_len > drvdata->ram_size) {
-		cfg.sram_offset += total_len;
+	if (cfg.sram_offset + total_len > drvdata->ram_size)
 		goto overstep;
-	}
 
 	drvdata->ram_start = cfg.sram_offset / 4;
 	return 0;
Signature · 1 line
2.35.1
Reviewed-by on v1 1/2
#2 lore raw
In reply to Dan Carpenter

The commit message should be written in an imperative manner, such as "Fix X, make Y do Z"

For the code:

Konrad

Quoted 23 lines · Dan Carpenter

The "ret" variable needs to be signed for the error handling to work.

Fixes 4cbe60cf5ad6 ("soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)")
---
 drivers/soc/qcom/dcc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/qcom/dcc.c +2 -1
index d4101f79cb5d..1e2cbefc1655 100644
@@ -808,8 +808,9 @@ static ssize_t config_reset_write(struct file *filp,
 				  const char __user *user_buf, size_t count,
 				  loff_t *ppos)
 {
-	unsigned int val, ret;
+	unsigned int val;
 	struct dcc_drvdata *drvdata = filp->private_data;
+	int ret;
 
 	ret = kstrtouint_from_user(user_buf, count, 0, &val);
 	if (ret < 0)
#3 lore raw
Quoted 3 lines · Konrad Dybcio

The commit message should be written in an imperative manner, such as "Fix X, make Y do Z"

Imperative tense requirements are a symptom of bureaucracy run mad. I always want to push back against that. We accrete layers of requirements like case-bearing leaf beetles making armor out of poop.

regards,
dan carpenter

Reviewed-by on v1 1/2
#4 lore raw
In reply to Dan Carpenter
Quoted 1 line · Dan Carpenter

The "ret" variable needs to be signed for the error handling to work.

The fix looks good. I'm sorry I missed this one in review.

Quoted 22 lines
Fixes 4cbe60cf5ad6 ("soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)")
---
  drivers/soc/qcom/dcc.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/qcom/dcc.c +2 -1
index d4101f79cb5d..1e2cbefc1655 100644
@@ -808,8 +808,9 @@ static ssize_t config_reset_write(struct file *filp,
  				  const char __user *user_buf, size_t count,
  				  loff_t *ppos)
  {
-	unsigned int val, ret;
+	unsigned int val;
  	struct dcc_drvdata *drvdata = filp->private_data;
+	int ret;
 
  	ret = kstrtouint_from_user(user_buf, count, 0, &val);
  	if (ret < 0)