ACPI: NFIT: prevent underflow in acpi_nfit_ctl(

PATCH Superseded Dan Carpenter 1 participant 1 message Jan 19, 2023

Subsystems (3)

Kernel janitors ACPI libnvdimm: non-volatile memory device

lore

Share & tools

lore

Dan Carpenter

author

2023-01-19 14:47 UTC #0 lore raw

PATCH 1/1 ACPI: NFIT: prevent underflow in acpi_nfit_ctl(

The concern here would be that "family" is negative and we pass a negative value to test_bit() resulting in an out of bounds read and potentially a crash.

This patch is based on static analysis and not on testing.

Fixes 9a7e3d7f0568 ("ACPI: NFIT: Fix input validation of bus-family")

Signed-off-by Dan Carpenter <[email protected]>

---
Another idea would be that we could change test_bit() to not accept bits higher than INT_MAX.

 drivers/acpi/nfit/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/acpi/nfit/core.c +1 -1

index f1cc5ec6a3b6..da0739f04c98 100644
@@ -446,10 +446,10 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
 	const char *cmd_name, *dimm_name;
 	unsigned long cmd_mask, dsm_mask;
 	u32 offset, fw_status = 0;
+	unsigned int family = 0;
 	acpi_handle handle;
 	const guid_t *guid;
 	int func, rc, i;
-	int family = 0;
 
 	if (cmd_rc)
 		*cmd_rc = -EINVAL;

Signature · 1 line

2.35.1