Skip to contentSkip to conversation

linux-user: Show 4th argument of rt_sigprocmask() in strace

PATCH Applied Helge Deller 3 participants 4 messages Jan 30, 2023 – Jan 31, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 linux-user: Show 4th argument of rt_sigprocmask() in strace

Add output for the missing 4th parameter (size_t sigsetsize).

---
v2: Use %u instead of %d, as suggested by Laurent Vivier

linux-user/strace.c +2 -1
index 3157e4b420..f0f6ada8cb 100644
@@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
     }
     qemu_log("%s,", how);
     print_pointer(arg1, 0);
-    print_pointer(arg2, 1);
+    print_pointer(arg2, 0);
+    print_raw_param("%u", arg3, 1);
     print_syscall_epilogue(name);
 }
 #endif
Reviewed-by on v2 1/1
#2 lore raw
In reply to Helge Deller

Le 30/01/2023 à 23:20, Helge Deller a écrit :

Quoted 13 lines

Add output for the missing 4th parameter (size_t sigsetsize).

---
v2: Use %u instead of %d, as suggested by Laurent Vivier

linux-user/strace.c +0 -0
index 3157e4b420..f0f6ada8cb 100644

linux-user/strace.c print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name, · line 3153

Quoted 9 lines
linux-user/strace.c +2 -1
@@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
      }
      qemu_log("%s,", how);
      print_pointer(arg1, 0);
-    print_pointer(arg2, 1);
+    print_pointer(arg2, 0);
+    print_raw_param("%u", arg3, 1);
      print_syscall_epilogue(name);
  }
  #endif
#3 lore raw
In reply to Helge Deller

Le 30/01/2023 à 23:20, Helge Deller a écrit :

Quoted 13 lines

Add output for the missing 4th parameter (size_t sigsetsize).

---
v2: Use %u instead of %d, as suggested by Laurent Vivier

linux-user/strace.c +0 -0
index 3157e4b420..f0f6ada8cb 100644

linux-user/strace.c print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name, · line 3153

Quoted 9 lines
linux-user/strace.c +2 -1
@@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
      }
      qemu_log("%s,", how);
      print_pointer(arg1, 0);
-    print_pointer(arg2, 1);
+    print_pointer(arg2, 0);
+    print_raw_param("%u", arg3, 1);
      print_syscall_epilogue(name);
  }
  #endif

Applied to my linux-user-for-8.0 branch.

Thanks,
Laurent