Skip to contentSkip to conversation

mtd: rawnand: fsmc: Fix error code in fsmc_nand_probe()

PATCH Applied Dan Carpenter 2 participants 2 messages Feb 15, 2021 – Mar 2, 2021

Subsystems (3)
Kernel janitors Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 mtd: rawnand: fsmc: Fix error code in fsmc_nand_probe()

If dma_request_channel() fails then the probe fails and it should return a negative error code, but currently it returns success.

Fixes 4774fb0a48aa ("mtd: nand/fsmc: Add DMA support")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/mtd/nand/raw/fsmc_nand.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/nand/raw/fsmc_nand.c +2 -0
index 0101c0fab50a..a24e2f57fa68 100644
@@ -1077,11 +1077,13 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
 		host->read_dma_chan = dma_request_channel(mask, filter, NULL);
 		if (!host->read_dma_chan) {
 			dev_err(&pdev->dev, "Unable to get read dma channel\n");
+			ret = -ENODEV;
 			goto disable_clk;
 		}
 		host->write_dma_chan = dma_request_channel(mask, filter, NULL);
 		if (!host->write_dma_chan) {
 			dev_err(&pdev->dev, "Unable to get write dma channel\n");
+			ret = -ENODEV;
 			goto release_dma_read_chan;
 		}
 	}
Signature · 1 line
2.30.0