Skip to contentSkip to conversation

vdpa: introduce virtio pci driver

bug report Dan Carpenter 1 participant 1 message Feb 25, 2021 virtio core

lore
Share & tools
lore
#0 lore raw

Hello Jason Wang,

The patch 010eee82c84e: "vdpa: introduce virtio pci driver" from Feb 23, 2021, leads to the following static checker warning:

	drivers/vdpa/virtio_pci/vp_vdpa.c:168 vp_vdpa_request_irq()
	warn: inconsistent indenting

drivers/vdpa/virtio_pci/vp_vdpa.c
154 goto err;

   155                  }
   156                  vp_modern_queue_vector(mdev, i, i);
   157                  vp_vdpa->vring[i].irq = irq;
   158          }
   159  
   160          snprintf(vp_vdpa->msix_name, VP_VDPA_NAME_SIZE, "vp-vdpa[%s]-config\n",
   161                   pci_name(pdev));
   162          irq = pci_irq_vector(pdev, queues);
   163          ret = devm_request_irq(&pdev->dev, irq, vp_vdpa_config_handler, 0,
   164                                 vp_vdpa->msix_name, vp_vdpa);
   165          if (ret) {
   166                  dev_err(&pdev->dev,
   167                          "vp_vdpa: fail to request irq for vq %d\n", i);
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Is this error message right?

   168                          goto err;
                                ^^^^^^^^

indented too far

   169          }
   170          vp_modern_config_vector(mdev, queues);
   171          vp_vdpa->config_irq = irq;

172
173 return 0;
174 err:
175 vp_vdpa_free_irq(vp_vdpa);
176 return ret;
177 }

regards,
dan carpenter
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization