staging: rtl8192u: fix ->ssid overflow in r8192_wx_set_scan()

PATCH New Dan Carpenter 1 participant 1 message Mar 5, 2021

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2021-03-05 08:13 UTC #0 lore raw

PATCH 1/1 staging: rtl8192u: fix ->ssid overflow in r8192_wx_set_scan()

We need to cap len at IW_ESSID_MAX_SIZE (32) to avoid memory corruption. This can be controlled by the user via the ioctl.

Fixes 5f53d8ca3d5d ("Staging: add rtl8192SU wireless usb driver")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/staging/rtl8192u/r8192U_wx.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/staging/rtl8192u/r8192U_wx.c +4 -2

index 175bb8b15389..5211b2005763 100644
@@ -331,8 +331,10 @@ static int r8192_wx_set_scan(struct net_device *dev, struct iw_request_info *a,
 		struct iw_scan_req *req = (struct iw_scan_req *)b;
 
 		if (req->essid_len) {
-			ieee->current_network.ssid_len = req->essid_len;
-			memcpy(ieee->current_network.ssid, req->essid, req->essid_len);
+			int len = min_t(int, req->essid_len, IW_ESSID_MAX_SIZE);
+
+			ieee->current_network.ssid_len = len;
+			memcpy(ieee->current_network.ssid, req->essid, len);
 		}
 	}

Signature · 1 line

2.30.1