scsi: sg: Fix a use after free on error in sg_add_sfp()
Subsystems (3)
PATCH 1/1 scsi: sg: Fix a use after free on error in sg_add_sfp()
The SG_LOG() error message dereferences "sfp" so move the kfree down a couple lines.
Fixes af1fc95db445 ("scsi: sg: Replace rq array with xarray")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/scsi/sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/sg.c +1 -1
@@ -3799,10 +3799,10 @@ sg_add_sfp(struct sg_device *sdp)if (rbuf_len >0 ) { srp =sg_build_reserve (sfp, rbuf_len);if (IS_ERR (srp)) { -kfree (sfp); err =PTR_ERR (srp);SG_LOG (1 , sfp,"%s: build reserve err=%ld\n" , __func__, -err); +kfree (sfp);return ERR_PTR (err); }if (srp->sgat_h.buflen < rbuf_len) {
Signature · 1 line
2.30.1