Issue with kfence and kmemleak
Subsystems (3)
Hi!
This is probably a known issue, but just in case: looks like it's not possible to use kmemleak when kfence is enabled:
[ 0.272136] kmemleak: Cannot insert 0xffff888236e02f00 into the object search tree (overlaps existing) [ 0.272136] CPU: 0 PID: 8 Comm: kthreadd Not tainted 5.12.0-rc3+ #92 [ 0.272136] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014 [ 0.272136] Call Trace: [ 0.272136] dump_stack+0x6d/0x89 [ 0.272136] create_object.isra.0.cold+0x40/0x62 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kmem_cache_alloc_trace+0x110/0x2f0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kthread+0x3f/0x150 [ 0.272136] ? lockdep_hardirqs_on_prepare+0xd4/0x170 [ 0.272136] ? __kthread_bind_mask+0x60/0x60 [ 0.272136] ret_from_fork+0x22/0x30 [ 0.272136] kmemleak: Kernel memory leak detector disabled [ 0.272136] kmemleak: Object 0xffff888236e00000 (size 2097152): [ 0.272136] kmemleak: comm "swapper", pid 0, jiffies 4294892296 [ 0.272136] kmemleak: min_count = 0 [ 0.272136] kmemleak: count = 0 [ 0.272136] kmemleak: flags = 0x1 [ 0.272136] kmemleak: checksum = 0 [ 0.272136] kmemleak: backtrace: [ 0.272136] memblock_alloc_internal+0x6d/0xb0 [ 0.272136] memblock_alloc_try_nid+0x6c/0x8a [ 0.272136] kfence_alloc_pool+0x26/0x3f [ 0.272136] start_kernel+0x242/0x548 [ 0.272136] secondary_startup_64_no_verify+0xb0/0xbb
I've tried the hack below but it didn't really helped. Obviously I don't really understand what's going on ;-) But I think the reason for this patch not working as (I) expected is because kfence is initialised *before* kmemleak.
mm/kfence/core.c +1 -0
@@ -631,6 +631,9 @@ void __init kfence_alloc_pool(void)if (!__kfence_pool)pr_err ("failed to allocate pool\n" ); +kmemleak_no_scan (__kfence_pool); }
Cheers,
--
Luís
Marco Elver
maintainerQuoted 4 lines · Luis Henriques
Hi!
This is probably a known issue, but just in case: looks like it's not possible to use kmemleak when kfence is enabled:
Thanks for spotting this.
Quoted 38 lines
[ 0.272136] kmemleak: Cannot insert 0xffff888236e02f00 into the object search tree (overlaps existing) [ 0.272136] CPU: 0 PID: 8 Comm: kthreadd Not tainted 5.12.0-rc3+ #92 [ 0.272136] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014 [ 0.272136] Call Trace: [ 0.272136] dump_stack+0x6d/0x89 [ 0.272136] create_object.isra.0.cold+0x40/0x62 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kmem_cache_alloc_trace+0x110/0x2f0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kthread+0x3f/0x150 [ 0.272136] ? lockdep_hardirqs_on_prepare+0xd4/0x170 [ 0.272136] ? __kthread_bind_mask+0x60/0x60 [ 0.272136] ret_from_fork+0x22/0x30 [ 0.272136] kmemleak: Kernel memory leak detector disabled [ 0.272136] kmemleak: Object 0xffff888236e00000 (size 2097152): [ 0.272136] kmemleak: comm "swapper", pid 0, jiffies 4294892296 [ 0.272136] kmemleak: min_count = 0 [ 0.272136] kmemleak: count = 0 [ 0.272136] kmemleak: flags = 0x1 [ 0.272136] kmemleak: checksum = 0 [ 0.272136] kmemleak: backtrace: [ 0.272136] memblock_alloc_internal+0x6d/0xb0 [ 0.272136] memblock_alloc_try_nid+0x6c/0x8a [ 0.272136] kfence_alloc_pool+0x26/0x3f [ 0.272136] start_kernel+0x242/0x548 [ 0.272136] secondary_startup_64_no_verify+0xb0/0xbbI've tried the hack below but it didn't really helped. Obviously I don't really understand what's going on ;-) But I think the reason for this patch not working as (I) expected is because kfence is initialised *before* kmemleak.
mm/kfence/core.c +0
-0
mm/kfence/core.c void __init kfence_alloc_pool(void) · line 635
Quoted 5 lines
mm/kfence/core.c +1
-0@@ -631,6 +631,9 @@ void __init kfence_alloc_pool(void)if (!__kfence_pool)pr_err ("failed to allocate pool\n" ); +kmemleak_no_scan (__kfence_pool); }
Can you try the below patch?
Thanks,
-- Marco
------ >8 ------
mm/kfence/core.c +8 -0
@@ -12,6 +12,7 @@#include <linux/debugfs.h> #include <linux/kcsan-checks.h> #include <linux/kfence.h> +#include <linux/kmemleak.h> #include <linux/list.h> #include <linux/lockdep.h> #include <linux/memblock.h>
@@ -481,6 +482,13 @@ static bool __init kfence_init_pool(void) addr +=2 *PAGE_SIZE ; } +/* +* The pool is live and will never be deallocated from this point on; +* tell kmemleak this is now free memory, so that later allocations can +* correctly be tracked. +*/ +kmemleak_free_part_phys (__pa (__kfence_pool),KFENCE_POOL_SIZE ); +return true; err:
Quoted 47 lines · Marco Elver
Quoted 4 lines · Luis Henriques
Hi!
This is probably a known issue, but just in case: looks like it's not possible to use kmemleak when kfence is enabled:
Thanks for spotting this.
Quoted 39 lines
[ 0.272136] kmemleak: Cannot insert 0xffff888236e02f00 into the object search tree (overlaps existing) [ 0.272136] CPU: 0 PID: 8 Comm: kthreadd Not tainted 5.12.0-rc3+ #92 [ 0.272136] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014 [ 0.272136] Call Trace: [ 0.272136] dump_stack+0x6d/0x89 [ 0.272136] create_object.isra.0.cold+0x40/0x62 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kmem_cache_alloc_trace+0x110/0x2f0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kthread+0x3f/0x150 [ 0.272136] ? lockdep_hardirqs_on_prepare+0xd4/0x170 [ 0.272136] ? __kthread_bind_mask+0x60/0x60 [ 0.272136] ret_from_fork+0x22/0x30 [ 0.272136] kmemleak: Kernel memory leak detector disabled [ 0.272136] kmemleak: Object 0xffff888236e00000 (size 2097152): [ 0.272136] kmemleak: comm "swapper", pid 0, jiffies 4294892296 [ 0.272136] kmemleak: min_count = 0 [ 0.272136] kmemleak: count = 0 [ 0.272136] kmemleak: flags = 0x1 [ 0.272136] kmemleak: checksum = 0 [ 0.272136] kmemleak: backtrace: [ 0.272136] memblock_alloc_internal+0x6d/0xb0 [ 0.272136] memblock_alloc_try_nid+0x6c/0x8a [ 0.272136] kfence_alloc_pool+0x26/0x3f [ 0.272136] start_kernel+0x242/0x548 [ 0.272136] secondary_startup_64_no_verify+0xb0/0xbbI've tried the hack below but it didn't really helped. Obviously I don't really understand what's going on ;-) But I think the reason for this patch not working as (I) expected is because kfence is initialised *before* kmemleak.
mm/kfence/core.c +0
-0@@ -631,6 +631,9 @@ void __init kfence_alloc_pool(void)
Quoted 6 lines
mm/kfence/core.c void __init kfence_alloc_pool(void) · line 635
Quoted 4 lines
mm/kfence/core.c +1
-0if (!__kfence_pool)pr_err ("failed to allocate pool\n" ); +kmemleak_no_scan (__kfence_pool); }Can you try the below patch?
Yep, that seems to fix the issue. Feel free to add my Tested-by. Thanks!
Cheers,
--
Luís
Quoted 32 lines
Thanks,
-- Marco------ >8 ------
mm/kfence/core.c +8
-0@@ -12,6 +12,7 @@#include <linux/debugfs.h> #include <linux/kcsan-checks.h> #include <linux/kfence.h> +#include <linux/kmemleak.h> #include <linux/list.h> #include <linux/lockdep.h> #include <linux/memblock.h> @@ -481,6 +482,13 @@ static bool __init kfence_init_pool(void) addr +=2 *PAGE_SIZE ; } +/* +* The pool is live and will never be deallocated from this point on; +* tell kmemleak this is now free memory, so that later allocations can +* correctly be tracked. +*/ +kmemleak_free_part_phys (__pa (__kfence_pool),KFENCE_POOL_SIZE ); +return true; err:
Catalin Marinas
maintainerQuoted 68 lines · Marco Elver
Quoted 41 lines · Luis Henriques
This is probably a known issue, but just in case: looks like it's not possible to use kmemleak when kfence is enabled:
[ 0.272136] kmemleak: Cannot insert 0xffff888236e02f00 into the object search tree (overlaps existing) [ 0.272136] CPU: 0 PID: 8 Comm: kthreadd Not tainted 5.12.0-rc3+ #92 [ 0.272136] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014 [ 0.272136] Call Trace: [ 0.272136] dump_stack+0x6d/0x89 [ 0.272136] create_object.isra.0.cold+0x40/0x62 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kmem_cache_alloc_trace+0x110/0x2f0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kthread+0x3f/0x150 [ 0.272136] ? lockdep_hardirqs_on_prepare+0xd4/0x170 [ 0.272136] ? __kthread_bind_mask+0x60/0x60 [ 0.272136] ret_from_fork+0x22/0x30 [ 0.272136] kmemleak: Kernel memory leak detector disabled [ 0.272136] kmemleak: Object 0xffff888236e00000 (size 2097152): [ 0.272136] kmemleak: comm "swapper", pid 0, jiffies 4294892296 [ 0.272136] kmemleak: min_count = 0 [ 0.272136] kmemleak: count = 0 [ 0.272136] kmemleak: flags = 0x1 [ 0.272136] kmemleak: checksum = 0 [ 0.272136] kmemleak: backtrace: [ 0.272136] memblock_alloc_internal+0x6d/0xb0 [ 0.272136] memblock_alloc_try_nid+0x6c/0x8a [ 0.272136] kfence_alloc_pool+0x26/0x3f [ 0.272136] start_kernel+0x242/0x548 [ 0.272136] secondary_startup_64_no_verify+0xb0/0xbbI've tried the hack below but it didn't really helped. Obviously I don't really understand what's going on ;-) But I think the reason for this patch not working as (I) expected is because kfence is initialised *before* kmemleak.
mm/kfence/core.c +0
-0mm/kfence/core.c void __init kfence_alloc_pool(void) · line 635
Quoted 5 lines
mm/kfence/core.c +1
-0@@ -631,6 +631,9 @@ void __init kfence_alloc_pool(void)if (!__kfence_pool)pr_err ("failed to allocate pool\n" ); +kmemleak_no_scan (__kfence_pool); }Can you try the below patch?
Thanks,
-- Marco------ >8 ------
mm/kfence/core.c +1
-0@@ -12,6 +12,7 @@#include <linux/debugfs.h> #include <linux/kcsan-checks.h> #include <linux/kfence.h> +#include <linux/kmemleak.h> #include <linux/list.h> #include <linux/lockdep.h> #include <linux/memblock.h>
mm/kfence/core.c static bool __init kfence_init_pool(void) · line 490
Quoted 9 lines
mm/kfence/core.c +6
-0@@ -481,6 +482,13 @@ static bool __init kfence_init_pool(void) addr +=2 *PAGE_SIZE ; } +/* +* The pool is live and will never be deallocated from this point on; +* tell kmemleak this is now free memory, so that later allocations can +* correctly be tracked. +*/ +kmemleak_free_part_phys (__pa (__kfence_pool),KFENCE_POOL_SIZE );
I presume this pool does not refer any objects that are only tracked through pool pointers.
kmemleak_free() (or *_free_part) should work, no need for the _phys variant (which converts it back with __va).
Since we normally use kmemleak_ignore() (or no_scan) for objects we don't care about, I'd expand the comment that this object needs to be removed from the kmemleak object tree as it will overlap with subsequent allocations handled by kfence which return pointers within this range.
Signature · 1 line
Catalin
Marco Elver
maintainerQuoted 72 lines · Catalin Marinas
Quoted 71 lines · Marco Elver
Quoted 41 lines · Luis Henriques
This is probably a known issue, but just in case: looks like it's not possible to use kmemleak when kfence is enabled:
[ 0.272136] kmemleak: Cannot insert 0xffff888236e02f00 into the object search tree (overlaps existing) [ 0.272136] CPU: 0 PID: 8 Comm: kthreadd Not tainted 5.12.0-rc3+ #92 [ 0.272136] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014 [ 0.272136] Call Trace: [ 0.272136] dump_stack+0x6d/0x89 [ 0.272136] create_object.isra.0.cold+0x40/0x62 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kmem_cache_alloc_trace+0x110/0x2f0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kthread+0x3f/0x150 [ 0.272136] ? lockdep_hardirqs_on_prepare+0xd4/0x170 [ 0.272136] ? __kthread_bind_mask+0x60/0x60 [ 0.272136] ret_from_fork+0x22/0x30 [ 0.272136] kmemleak: Kernel memory leak detector disabled [ 0.272136] kmemleak: Object 0xffff888236e00000 (size 2097152): [ 0.272136] kmemleak: comm "swapper", pid 0, jiffies 4294892296 [ 0.272136] kmemleak: min_count = 0 [ 0.272136] kmemleak: count = 0 [ 0.272136] kmemleak: flags = 0x1 [ 0.272136] kmemleak: checksum = 0 [ 0.272136] kmemleak: backtrace: [ 0.272136] memblock_alloc_internal+0x6d/0xb0 [ 0.272136] memblock_alloc_try_nid+0x6c/0x8a [ 0.272136] kfence_alloc_pool+0x26/0x3f [ 0.272136] start_kernel+0x242/0x548 [ 0.272136] secondary_startup_64_no_verify+0xb0/0xbbI've tried the hack below but it didn't really helped. Obviously I don't really understand what's going on ;-) But I think the reason for this patch not working as (I) expected is because kfence is initialised *before* kmemleak.
mm/kfence/core.c +0
-0mm/kfence/core.c void __init kfence_alloc_pool(void) · line 635
Quoted 5 lines
mm/kfence/core.c +1
-0@@ -631,6 +631,9 @@ void __init kfence_alloc_pool(void)if (!__kfence_pool)pr_err ("failed to allocate pool\n" ); +kmemleak_no_scan (__kfence_pool); }Can you try the below patch?
Thanks,
-- Marco------ >8 ------
mm/kfence/core.c +1
-0@@ -12,6 +12,7 @@#include <linux/debugfs.h> #include <linux/kcsan-checks.h> #include <linux/kfence.h> +#include <linux/kmemleak.h> #include <linux/list.h> #include <linux/lockdep.h> #include <linux/memblock.h> @@ -481,6 +482,13 @@ static bool __init kfence_init_pool(void) addr +=2 *PAGE_SIZE ; }
Quoted 9 lines
mm/kfence/core.c static bool __init kfence_init_pool(void) · line 490
Quoted 6 lines
mm/kfence/core.c +6
-0+/* +* The pool is live and will never be deallocated from this point on; +* tell kmemleak this is now free memory, so that later allocations can +* correctly be tracked. +*/ +kmemleak_free_part_phys (__pa (__kfence_pool),KFENCE_POOL_SIZE );I presume this pool does not refer any objects that are only tracked through pool pointers.
No, at this point this memory should not have been touched by anything.
Quoted 2 lines
kmemleak_free()(or*_free_part) should work, no need for the_physvariant (which converts it back with__va).
Will fix.
Quoted 4 lines
Since we normally use
kmemleak_ignore()(orno_scan) for objects we don't care about, I'd expand the comment that this object needs to be removed from the kmemleak object tree as it will overlap with subsequent allocations handled by kfence which return pointers within this range.
One thing I've just run into: "BUG: KFENCE: out-of-bounds read in scan_block+0x6b/0x170 mm/kmemleak.c:1244"
Probably because kmemleak is passed the rounded size for the size-class, and not the real allocation size. Can this be fixed with kmemleak_ignore() only called on the KFENCE guard pages?
I'd like kmemleak to scan the valid portion of an object allocated through KFENCE, but no further than that.
Or do we need to fix the size if it's a kfence object:
mm/kmemleak.c +2 -1
@@ -97,6 +97,7 @@#include <linux/atomic.h> #include <linux/kasan.h> +#include <linux/kfence.h> #include <linux/kmemleak.h> #include <linux/memory_hotplug.h>
@@ -589,7 +590,7 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size,atomic_set (&object->use_count,1 ); object->flags =OBJECT_ALLOCATED ; object->pointer = ptr; - object->size = size; + object->size =kfence_ksize ((void *)ptr) ?: size; object->excess_ref =0 ; object->min_count = min_count; object->count =0 ;/* white color initially */
The alternative is to call kfence_ksize() in slab_post_alloc_hook() when calling kmemleak_alloc.
Do you have a preference?
Thanks,
-- Marco
Catalin Marinas
maintainerQuoted 6 lines · Marco Elver
One thing I've just run into: "BUG: KFENCE: out-of-bounds read in
scan_block+0x6b/0x170mm/kmemleak.c:1244"Probably because kmemleak is passed the rounded size for the size-class, and not the real allocation size. Can this be fixed with
kmemleak_ignore()only called on the KFENCE guard pages?
If it's only on the occasional object, you can do a kmemleak_scan_area() but some care needed as this in turn allocates memory for kmemleak internal metadata.
Quoted 27 lines
I'd like kmemleak to scan the valid portion of an object allocated through KFENCE, but no further than that.
Or do we need to fix the size if it's a kfence object:
mm/kmemleak.c +2
-1@@ -97,6 +97,7 @@#include <linux/atomic.h> #include <linux/kasan.h> +#include <linux/kfence.h> #include <linux/kmemleak.h> #include <linux/memory_hotplug.h> @@ -589,7 +590,7 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size,atomic_set (&object->use_count,1 ); object->flags =OBJECT_ALLOCATED ; object->pointer = ptr; - object->size = size; + object->size =kfence_ksize ((void *)ptr) ?: size; object->excess_ref =0 ; object->min_count = min_count; object->count =0 ;/* white color initially */
Quoted 2 lines
The alternative is to call
kfence_ksize()inslab_post_alloc_hook()when callingkmemleak_alloc.
One of these is probably the easiest. If kfence only works on slab objects, better to pass the right size from slab_post_alloc_hook(). If you plan to expand it later to vmalloc(), just fix the size in create_object().
Signature · 1 line
Catalin
Quoted 90 lines · Marco Elver
Quoted 72 lines · Catalin Marinas
Quoted 71 lines · Marco Elver
Quoted 41 lines · Luis Henriques
This is probably a known issue, but just in case: looks like it's not possible to use kmemleak when kfence is enabled:
[ 0.272136] kmemleak: Cannot insert 0xffff888236e02f00 into the object search tree (overlaps existing) [ 0.272136] CPU: 0 PID: 8 Comm: kthreadd Not tainted 5.12.0-rc3+ #92 [ 0.272136] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014 [ 0.272136] Call Trace: [ 0.272136] dump_stack+0x6d/0x89 [ 0.272136] create_object.isra.0.cold+0x40/0x62 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kmem_cache_alloc_trace+0x110/0x2f0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kthread+0x3f/0x150 [ 0.272136] ? lockdep_hardirqs_on_prepare+0xd4/0x170 [ 0.272136] ? __kthread_bind_mask+0x60/0x60 [ 0.272136] ret_from_fork+0x22/0x30 [ 0.272136] kmemleak: Kernel memory leak detector disabled [ 0.272136] kmemleak: Object 0xffff888236e00000 (size 2097152): [ 0.272136] kmemleak: comm "swapper", pid 0, jiffies 4294892296 [ 0.272136] kmemleak: min_count = 0 [ 0.272136] kmemleak: count = 0 [ 0.272136] kmemleak: flags = 0x1 [ 0.272136] kmemleak: checksum = 0 [ 0.272136] kmemleak: backtrace: [ 0.272136] memblock_alloc_internal+0x6d/0xb0 [ 0.272136] memblock_alloc_try_nid+0x6c/0x8a [ 0.272136] kfence_alloc_pool+0x26/0x3f [ 0.272136] start_kernel+0x242/0x548 [ 0.272136] secondary_startup_64_no_verify+0xb0/0xbbI've tried the hack below but it didn't really helped. Obviously I don't really understand what's going on ;-) But I think the reason for this patch not working as (I) expected is because kfence is initialised *before* kmemleak.
mm/kfence/core.c +0
-0mm/kfence/core.c void __init kfence_alloc_pool(void) · line 635
Quoted 5 lines
mm/kfence/core.c +1
-0@@ -631,6 +631,9 @@ void __init kfence_alloc_pool(void)if (!__kfence_pool)pr_err ("failed to allocate pool\n" ); +kmemleak_no_scan (__kfence_pool); }Can you try the below patch?
Thanks,
-- Marco------ >8 ------
mm/kfence/core.c +1
-0@@ -12,6 +12,7 @@#include <linux/debugfs.h> #include <linux/kcsan-checks.h> #include <linux/kfence.h> +#include <linux/kmemleak.h> #include <linux/list.h> #include <linux/lockdep.h> #include <linux/memblock.h> @@ -481,6 +482,13 @@ static bool __init kfence_init_pool(void) addr +=2 *PAGE_SIZE ; }Quoted 9 lines
mm/kfence/core.c static bool __init kfence_init_pool(void) · line 490
Quoted 6 lines
mm/kfence/core.c +6
-0+/* +* The pool is live and will never be deallocated from this point on; +* tell kmemleak this is now free memory, so that later allocations can +* correctly be tracked. +*/ +kmemleak_free_part_phys (__pa (__kfence_pool),KFENCE_POOL_SIZE );I presume this pool does not refer any objects that are only tracked through pool pointers.
No, at this point this memory should not have been touched by anything.
Quoted 2 lines
kmemleak_free()(or*_free_part) should work, no need for the_physvariant (which converts it back with__va).Will fix.
Quoted 7 lines
Quoted 4 lines
Since we normally use
kmemleak_ignore()(orno_scan) for objects we don't care about, I'd expand the comment that this object needs to be removed from the kmemleak object tree as it will overlap with subsequent allocations handled by kfence which return pointers within this range.One thing I've just run into: "BUG: KFENCE: out-of-bounds read in
scan_block+0x6b/0x170mm/kmemleak.c:1244"
FWIW, I just saw this as well. It doesn't happen every time, but yeah I missed it in my initial testing.
Cheers,
--
Luís
Quoted 40 lines
Probably because kmemleak is passed the rounded size for the size-class, and not the real allocation size. Can this be fixed with
kmemleak_ignore()only called on the KFENCE guard pages?I'd like kmemleak to scan the valid portion of an object allocated through KFENCE, but no further than that.
Or do we need to fix the size if it's a kfence object:
mm/kmemleak.c +2
-1@@ -97,6 +97,7 @@#include <linux/atomic.h> #include <linux/kasan.h> +#include <linux/kfence.h> #include <linux/kmemleak.h> #include <linux/memory_hotplug.h> @@ -589,7 +590,7 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size,atomic_set (&object->use_count,1 ); object->flags =OBJECT_ALLOCATED ; object->pointer = ptr; - object->size = size; + object->size =kfence_ksize ((void *)ptr) ?: size; object->excess_ref =0 ; object->min_count = min_count; object->count =0 ;/* white color initially */ The alternative is to call
kfence_ksize()inslab_post_alloc_hook()when callingkmemleak_alloc.Do you have a preference?
Thanks,
-- Marco
Marco Elver
maintainerQuoted 96 lines · Luis Henriques
Quoted 95 lines · Marco Elver
Quoted 72 lines · Catalin Marinas
Quoted 71 lines · Marco Elver
Quoted 41 lines · Luis Henriques
This is probably a known issue, but just in case: looks like it's not possible to use kmemleak when kfence is enabled:
[ 0.272136] kmemleak: Cannot insert 0xffff888236e02f00 into the object search tree (overlaps existing) [ 0.272136] CPU: 0 PID: 8 Comm: kthreadd Not tainted 5.12.0-rc3+ #92 [ 0.272136] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014 [ 0.272136] Call Trace: [ 0.272136] dump_stack+0x6d/0x89 [ 0.272136] create_object.isra.0.cold+0x40/0x62 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kmem_cache_alloc_trace+0x110/0x2f0 [ 0.272136] ? process_one_work+0x5a0/0x5a0 [ 0.272136] kthread+0x3f/0x150 [ 0.272136] ? lockdep_hardirqs_on_prepare+0xd4/0x170 [ 0.272136] ? __kthread_bind_mask+0x60/0x60 [ 0.272136] ret_from_fork+0x22/0x30 [ 0.272136] kmemleak: Kernel memory leak detector disabled [ 0.272136] kmemleak: Object 0xffff888236e00000 (size 2097152): [ 0.272136] kmemleak: comm "swapper", pid 0, jiffies 4294892296 [ 0.272136] kmemleak: min_count = 0 [ 0.272136] kmemleak: count = 0 [ 0.272136] kmemleak: flags = 0x1 [ 0.272136] kmemleak: checksum = 0 [ 0.272136] kmemleak: backtrace: [ 0.272136] memblock_alloc_internal+0x6d/0xb0 [ 0.272136] memblock_alloc_try_nid+0x6c/0x8a [ 0.272136] kfence_alloc_pool+0x26/0x3f [ 0.272136] start_kernel+0x242/0x548 [ 0.272136] secondary_startup_64_no_verify+0xb0/0xbbI've tried the hack below but it didn't really helped. Obviously I don't really understand what's going on ;-) But I think the reason for this patch not working as (I) expected is because kfence is initialised *before* kmemleak.
mm/kfence/core.c +0
-0mm/kfence/core.c void __init kfence_alloc_pool(void) · line 635
Quoted 5 lines
mm/kfence/core.c +1
-0@@ -631,6 +631,9 @@ void __init kfence_alloc_pool(void)if (!__kfence_pool)pr_err ("failed to allocate pool\n" ); +kmemleak_no_scan (__kfence_pool); }Can you try the below patch?
Thanks,
-- Marco------ >8 ------
mm/kfence/core.c +1
-0@@ -12,6 +12,7 @@#include <linux/debugfs.h> #include <linux/kcsan-checks.h> #include <linux/kfence.h> +#include <linux/kmemleak.h> #include <linux/list.h> #include <linux/lockdep.h> #include <linux/memblock.h> @@ -481,6 +482,13 @@ static bool __init kfence_init_pool(void) addr +=2 *PAGE_SIZE ; }Quoted 9 lines
mm/kfence/core.c static bool __init kfence_init_pool(void) · line 490
Quoted 6 lines
mm/kfence/core.c +6
-0+/* +* The pool is live and will never be deallocated from this point on; +* tell kmemleak this is now free memory, so that later allocations can +* correctly be tracked. +*/ +kmemleak_free_part_phys (__pa (__kfence_pool),KFENCE_POOL_SIZE );I presume this pool does not refer any objects that are only tracked through pool pointers.
No, at this point this memory should not have been touched by anything.
Quoted 2 lines
kmemleak_free()(or*_free_part) should work, no need for the_physvariant (which converts it back with__va).Will fix.
Quoted 4 lines
Since we normally use
kmemleak_ignore()(orno_scan) for objects we don't care about, I'd expand the comment that this object needs to be removed from the kmemleak object tree as it will overlap with subsequent allocations handled by kfence which return pointers within this range.
Quoted 5 lines
Quoted 2 lines
One thing I've just run into: "BUG: KFENCE: out-of-bounds read in
scan_block+0x6b/0x170mm/kmemleak.c:1244"FWIW, I just saw this as well. It doesn't happen every time, but yeah I missed it in my initial testing.
I've just sent the patch, please re-test if you can:
https://lkml.kernel.org/r/[email protected]
Thanks!