usbip: tools: add options and examples in man page related to device mode

PATCH Superseded Hongren Zheng (Zenithal) 3 participants 10 messages Mar 23, 2021 – Mar 24, 2021

Subsystems (2)

USB USB over IP driver

lore

Share & tools

lore

Hongren Zheng (Zenithal)

author reviewer

2021-03-23 12:56 UTC #0 lore raw

PATCH v4 1/2 usbip: tools: add options and examples in man page related to device mode

The commit e0546fd8b748 ("usbip: tools: Start using VUDC backend in usbip tools") implemented device mode for user space tools, however the corresponding options are not documented in man page.

This commit documents the options and provides examples on device mode.

Signed-off-by Hongren Zheng <[email protected]>

---
 tools/usb/usbip/doc/usbip.8  | 25 +++++++++++++++++++++++++
 tools/usb/usbip/doc/usbipd.8 | 22 ++++++++++++++++++++++
 2 files changed, 47 insertions(+)

PATCH v2:
Add signed-off-by line

PATCH v3:
Move patch changelog after the marker line
Remove nickname in signed-off-by line

PATCH v4:
Use commit short hash and message instead of long hash only when
referring to commit in the kernel

tools/usb/usbip/doc/usbip.8 +25 -0

index a15d20063b98..385b0eda8746 100644
@@ -49,6 +49,13 @@ then exit.
 Attach a remote USB device.
 .PP
 
+.HP
+\fBattach\fR \-\-remote=<\fIhost\fR> \-\-device=<\fdev_id\fR>
+.IP
+Attach a remote USB gadget.
+Only used when the remote usbipd is in device mode.
+.PP
+
 .HP
 \fBdetach\fR \-\-port=<\fIport\fR>
 .IP

@@ -73,6 +80,14 @@ Stop exporting a device so it can be used by a local driver.
 List USB devices exported by a remote host.
 .PP
 
+.HP
+\fBlist\fR \-\-device
+.IP
+List USB gadgets of local usbip-vudc.
+Only used when the local usbipd is in device mode.
+This can not list usbip-vudc USB gadgets of the remote device mode usbipd.
+.PP
+
 .HP
 \fBlist\fR \-\-local
 .IP

@@ -93,5 +108,15 @@ List local USB devices.
     client:# usbip detach --port=0
         - Detach the usb device.
 
+The following example shows the use of device mode
+
+    server:# usbip list --device
+        - Note this is the server side
+
+    client:# modprobe vhci-hcd
+
+    client:# usbip attach --remote=server --device=usbip-vudc.0
+        - Connect the remote USB gadget
+
 .SH "SEE ALSO"
 \fBusbipd\fP\fB(8)\fB\fP

tools/usb/usbip/doc/usbipd.8 +22 -0

index fb62a756893b..53c8d5792de6 100644
@@ -29,6 +29,12 @@ Bind to IPv4. Default is both.
 Bind to IPv6. Default is both.
 .PP
 
+.HP
+\fB\-e\fR, \fB\-\-device\fR
+.IP
+Run in device mode. Rather than drive an attached device, create a virtual UDC to bind gadgets to.
+.PP
+
 .HP
 \fB\-D\fR, \fB\-\-daemon\fR
 .IP

@@ -86,6 +92,22 @@ USB/IP client can connect and use exported devices.
         - A usb device 1-2 is now exportable to other hosts!
         - Use 'usbip unbind --busid=1-2' when you want to shutdown exporting and use the device locally.
 
+The following example shows the use of device mode
+
+    server:# modprobe usbip-vudc
+        - Use /sys/class/udc/ interface
+        - usbip-host is independent of this module.
+
+    server:# usbipd -e -D
+        - Start usbip daemon in device mode.
+
+    server:# modprobe g_mass_storage file=/tmp/tmp.img
+        - Bind a gadget to usbip-vudc
+        - in this example, a mass storage gadget is bound
+
+    server:# usbip list --device
+        - Note this is the server side
+
 .SH "SEE ALSO"
 \fBusbip\fP\fB(8)\fB\fP

Signature · 1 line

2.30.1

Hongren Zheng (Zenithal)

author reviewer

2021-03-23 13:02 UTC #1 lore raw

PATCH v4 2/2 usbip: tools: add usage of device mode in usbip_list.c

The option '-d/--device' was implemented in 'usbip list' but not shown in usage. Hence this commit adds this option to usage.

Signed-off-by Hongren Zheng <[email protected]>

---
 tools/usb/usbip/src/usbip_list.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

PATCH v2:
Add signed-off-by line

PATCH v3:
Move patch changelog after the marker line
Remove nickname in signed-off-by line

PATCH v4:
Use commit short hash and message instead of long hash only when
referring to commit in the kernel

tools/usb/usbip/src/usbip_list.c +2 -1

index 8625b0f514ee..3d810bcca02f 100644
@@ -33,7 +33,8 @@ static const char usbip_list_usage_string[] =
 	"usbip list [-p|--parsable] <args>\n"
 	"    -p, --parsable         Parsable list format\n"
 	"    -r, --remote=<host>    List the exportable USB devices on <host>\n"
-	"    -l, --local            List the local USB devices\n";
+	"    -l, --local            List the local USB devices\n"
+	"    -d, --device           List the local USB gadgets bound to usbip-vudc\n";
 
 void usbip_list_usage(void)
 {

Signature · 1 line

2.30.1

Shuah Khan

maintainer Acked-by on v4 2/2

2021-03-23 15:46 UTC #2 lore raw

Re: [PATCH v4 2/2] usbip: tools: add usage of device mode in usbip_list.c

Quoted 25 lines · Hongren Zheng (Zenithal)

The option '-d/--device' was implemented in 'usbip list' but not shown in usage. Hence this commit adds this option to usage.
Signed-off-by Hongren Zheng <[email protected]>
---
  tools/usb/usbip/src/usbip_list.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
PATCH v2:
Add signed-off-by line
PATCH v3:
Move patch changelog after the marker line
Remove nickname in signed-off-by line
PATCH v4:
Use commit short hash and message instead of long hash only when
referring to commit in the kernel
tools/usb/usbip/src/usbip_list.c +0 -0
index 8625b0f514ee..3d810bcca02f 100644

tools/usb/usbip/src/usbip_list.c static const char usbip_list_usage_string[] = · line 40

Quoted 9 lines

tools/usb/usbip/src/usbip_list.c +2 -1

@@ -33,7 +33,8 @@ static const char usbip_list_usage_string[] =
  	"usbip list [-p|--parsable] <args>\n"
  	"    -p, --parsable         Parsable list format\n"
  	"    -r, --remote=<host>    List the exportable USB devices on <host>\n"
-	"    -l, --local            List the local USB devices\n";
+	"    -l, --local            List the local USB devices\n"
+	"    -d, --device           List the local USB gadgets bound to usbip-vudc\n";
 
  void usbip_list_usage(void)
  {

Looks good to me. Thanks for adding this.

Acked-by Shuah Khan <[email protected]>

thanks,
-- Shuah

Hongren Zheng (Zenithal)

author reviewer

2021-03-24 04:37 UTC #4 lore raw

Quoted 40 lines · Shuah Khan

Quoted 15 lines · Hongren Zheng (Zenithal)
The commit e0546fd8b748 ("usbip: tools: Start using VUDC backend in usbip tools") implemented device mode for user space tools, however the corresponding options are not documented in man page.
This commit documents the options and provides examples on device mode.
Signed-off-by Hongren Zheng <[email protected]>
---
  tools/usb/usbip/doc/usbip.8  | 25 +++++++++++++++++++++++++
  tools/usb/usbip/doc/usbipd.8 | 22 ++++++++++++++++++++++
  2 files changed, 47 insertions(+)
PATCH v2:
Add signed-off-by line
Quoted 8 lines
PATCH v3:
Move patch changelog after the marker line
Remove nickname in signed-off-by line
PATCH v4:
Use commit short hash and message instead of long hash only when
referring to commit in the kernel
Thank you for the patch. Please see comments below:
Quoted 13 lines
tools/usb/usbip/doc/usbip.8 +6 -0
index a15d20063b98..385b0eda8746 100644
@@ -49,6 +49,13 @@ then exit.
  Attach a remote USB device.
  .PP
+.HP
+\fBattach\fR \-\-remote=<\fIhost\fR> \-\-device=<\fdev_id\fR>
+.IP
+Attach a remote USB gadget.
+Only used when the remote usbipd is in device mode.
+.PP

Quoted 8 lines

tools/usb/usbip/doc/usbip.8 then exit. · line 61
Quoted 4 lines
tools/usb/usbip/doc/usbip.8 +1 -0
+
  .HP
  \fBdetach\fR \-\-port=<\fIport\fR>
  .IP
This is a bit confusing. Please add a separate section for Attach a remote USB gadget complete with attach and detach instructions.

The detaching of a USB device and a USB gadget share the same detach command. You attach one USB device/gadget use either one of the above attach commands, and when you need to detach one device/gadget, you first need usbip port to show the port of imported device/gadget, for example,

client:# usbip port
Imported USB devices
====================
Port 00: <Port in Use> at High Speed(480Mbps)

       Netchip Technology, Inc. : Pocketbook Pro 903 / Mobius 2 Action Cam / xDuoo X3 / PocketBook Pro 602
       3-1 -> usbip://localhost:3240/usbip-vudc.0
           -> remote bus/dev 000/000

then use usbip detach --port=0 to detach the device/gadget. Since they share the same workflow for detaching, a separate section may not be necessary.

Meanwhile, in the example below a detach command for device mode can be added. With the example I think the complete flow for device mode would be made clear enough.

I will send a new version of this patch with this command added in the example, some description rephrased and typo fixed.

Quoted 72 lines

Quoted 58 lines

tools/usb/usbip/doc/usbip.8 +18 -0

@@ -73,6 +80,14 @@ Stop exporting a device so it can be used by a local driver.
  List USB devices exported by a remote host.
  .PP
+.HP
+\fBlist\fR \-\-device
+.IP
+List USB gadgets of local usbip-vudc.
+Only used when the local usbipd is in device mode.
+This can not list usbip-vudc USB gadgets of the remote device mode usbipd.
+.PP
+
  .HP
  \fBlist\fR \-\-local
  .IP

@@ -93,5 +108,15 @@ List local USB devices.
      client:# usbip detach --port=0
          - Detach the usb device.
+The following example shows the use of device mode
+
+    server:# usbip list --device
+        - Note this is the server side
+
+    client:# modprobe vhci-hcd
+
+    client:# usbip attach --remote=server --device=usbip-vudc.0
+        - Connect the remote USB gadget
+
  .SH "SEE ALSO"
  \fBusbipd\fP\fB(8)\fB\fP

tools/usb/usbip/doc/usbipd.8 +15 -0

index fb62a756893b..53c8d5792de6 100644
@@ -29,6 +29,12 @@ Bind to IPv4. Default is both.
  Bind to IPv6. Default is both.
  .PP
+.HP
+\fB\-e\fR, \fB\-\-device\fR
+.IP
+Run in device mode. Rather than drive an attached device, create a virtual UDC to bind gadgets to.
+.PP
+
  .HP
  \fB\-D\fR, \fB\-\-daemon\fR
  .IP

@@ -86,6 +92,22 @@ USB/IP client can connect and use exported devices.
          - A usb device 1-2 is now exportable to other hosts!
          - Use 'usbip unbind --busid=1-2' when you want to shutdown exporting and use the device locally.
+The following example shows the use of device mode
+
+    server:# modprobe usbip-vudc
+        - Use /sys/class/udc/ interface
+        - usbip-host is independent of this module.
+
+    server:# usbipd -e -D
+        - Start usbip daemon in device mode.
+

tools/usb/usbip/doc/usbipd.8 USB/IP client can connect and use exported devices. · line 112

Quoted 10 lines

tools/usb/usbip/doc/usbipd.8 +7 -0

+    server:# modprobe g_mass_storage file=/tmp/tmp.img
+        - Bind a gadget to usbip-vudc
+        - in this example, a mass storage gadget is bound
+
+    server:# usbip list --device
+        - Note this is the server side
+
  .SH "SEE ALSO"
  \fBusbip\fP\fB(8)\fB\fP

thanks,
-- Shuah

Hongren Zheng (Zenithal)

author reviewer

2021-03-24 06:36 UTC #5 lore raw

PATCH v5 1/2 usbip: tools: add options and examples in man page related to device mode

The commit e0546fd8b748 ("usbip: tools: Start using VUDC backend in usbip tools") implemented device mode for user space tools, however the corresponding options are not documented in man page.

This commit documents the options and provides examples on device mode. Also the command usbip port is documented.

Signed-off-by Hongren Zheng <[email protected]>

---
 tools/usb/usbip/doc/usbip.8  | 42 +++++++++++++++++++++++++++++++++++-
 tools/usb/usbip/doc/usbipd.8 | 26 ++++++++++++++++++++++
 2 files changed, 67 insertions(+), 1 deletion(-)

PATCH v2:
Add signed-off-by line

PATCH v3:
Move patch changelog after the marker line
Remove nickname in signed-off-by line

PATCH v4:
Use commit short hash and message instead of long hash only when
referring to commit in the kernel

PATCH v5:
Add documentation of usbip port and its usage in examples Add flow of detaching in examples
Rephrase some description and add punctuations Fix typo of usbip attach --ev-id to --dev-id

tools/usb/usbip/doc/usbip.8 +41 -1

index a15d20063b98..1f26e4a00638 100644
@@ -49,10 +49,17 @@ then exit.
 Attach a remote USB device.
 .PP
 
+.HP
+\fBattach\fR \-\-remote=<\fIhost\fR> \-\-device=<\fIdev_id\fR>
+.IP
+Attach a remote USB gadget.
+Only used when the remote usbipd is in device mode.
+.PP
+
 .HP
 \fBdetach\fR \-\-port=<\fIport\fR>
 .IP
-Detach an imported USB device.
+Detach an imported USB device/gadget.
 .PP
 
 .HP

@@ -73,12 +80,26 @@ Stop exporting a device so it can be used by a local driver.
 List USB devices exported by a remote host.
 .PP
 
+.HP
+\fBlist\fR \-\-device
+.IP
+List USB gadgets of local usbip-vudc.
+Only used when the local usbipd is in device mode.
+Note that this can not list usbip-vudc USB gadgets of the remote device mode usbipd.
+.PP
+
 .HP
 \fBlist\fR \-\-local
 .IP
 List local USB devices.
 .PP
 
+.HP
+\fBport\fR
+.IP
+List imported devices/gadgets.
+.PP
+
 
 .SH EXAMPLES

@@ -90,8 +111,27 @@ List local USB devices.
     client:# usbip attach --remote=server --busid=1-2
         - Connect the remote USB device.
 
+    client:# usbip port
+        - List imported devices/gadgets.
+
     client:# usbip detach --port=0
         - Detach the usb device.
 
+The following example shows the usage of device mode
+
+    server:# usbip list --device
+        - List gadgets exported by local usbipd server.
+
+    client:# modprobe vhci-hcd
+
+    client:# usbip attach --remote=server --device=usbip-vudc.0
+        - Connect the remote USB gadget.
+
+    client:# usbip port
+        - List imported devices/gadgets.
+
+    client:# usbip detach --port=0
+        - Detach the usb gadget.
+
 .SH "SEE ALSO"
 \fBusbipd\fP\fB(8)\fB\fP

tools/usb/usbip/doc/usbipd.8 +26 -0

index fb62a756893b..d974394f86a1 100644
@@ -29,6 +29,12 @@ Bind to IPv4. Default is both.
 Bind to IPv6. Default is both.
 .PP
 
+.HP
+\fB\-e\fR, \fB\-\-device\fR
+.IP
+Run in device mode. Rather than drive an attached device, create a virtual UDC to bind gadgets to.
+.PP
+
 .HP
 \fB\-D\fR, \fB\-\-daemon\fR
 .IP

@@ -86,6 +92,26 @@ USB/IP client can connect and use exported devices.
         - A usb device 1-2 is now exportable to other hosts!
         - Use 'usbip unbind --busid=1-2' when you want to shutdown exporting and use the device locally.
 
+The following example shows the usage of device mode
+
+    server:# modprobe usbip-vudc
+        - Use /sys/class/udc/ interface.
+        - usbip-host is independent of this module.
+
+    server:# usbipd -e -D
+        - Start usbip daemon in device mode.
+
+    server:# modprobe g_mass_storage file=/tmp/tmp.img
+        - Bind a gadget to usbip-vudc.
+        - in this example, a mass storage gadget is bound.
+
+    server:# usbip list --device
+        - List gadgets exported by local usbipd server.
+
+    server:# modprobe -r g_mass_storage
+        - Unbind a gadget from usbip-vudc.
+        - in this example, the previous mass storage gadget is unbound.
+
 .SH "SEE ALSO"
 \fBusbip\fP\fB(8)\fB\fP

Signature · 1 line

2.30.1

Greg Kroah-Hartman

maintainer

2021-03-24 07:37 UTC #6 lore raw

Quoted 4 lines · Hongren Zheng (Zenithal)

The commit e0546fd8b748 ("usbip: tools: Start using VUDC backend in usbip tools") implemented device mode for user space tools, however the corresponding options are not documented in man page.

Quoted 9 lines

This commit documents the options and provides examples on device mode. Also the command usbip port is documented.
Signed-off-by Hongren Zheng <[email protected]>
---
 tools/usb/usbip/doc/usbip.8  | 42 +++++++++++++++++++++++++++++++++++-
 tools/usb/usbip/doc/usbipd.8 | 26 ++++++++++++++++++++++
 2 files changed, 67 insertions(+), 1 deletion(-)

Always resend the whole series, not just individual patches of the series. When you send individual updates, it's almost impossible to figure out what patch is what to review and apply properly.

There's no "waste" by resending the whole series, it makes it obvious what is going on and what needs to be reviewed.

thanks,

greg k-h

Hongren Zheng (Zenithal)

author reviewer

2021-03-24 07:57 UTC #7 lore raw

PATCH v5 2/2 usbip: tools: add usage of device mode in usbip_list.c

In reply to Hongren Zheng (Zenithal)

The option '-d/--device' was implemented in 'usbip list' but not shown in usage. Hence this commit adds this option to usage.

Signed-off-by Hongren Zheng <[email protected]>

---
 tools/usb/usbip/src/usbip_list.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

PATCH v2:
Add signed-off-by line

PATCH v3:
Move patch changelog after the marker line
Remove nickname in signed-off-by line

PATCH v4:
Use commit short hash and message instead of long hash only when
referring to commit in the kernel

PATCH v5:
Add documentation of usbip port and its usage in examples Add flow of detaching in examples
Rephrase some description and add punctuations Fix typo of usbip attach --ev-id to --dev-id

tools/usb/usbip/src/usbip_list.c +2 -1

index 8625b0f514ee..3d810bcca02f 100644
@@ -33,7 +33,8 @@ static const char usbip_list_usage_string[] =
 	"usbip list [-p|--parsable] <args>\n"
 	"    -p, --parsable         Parsable list format\n"
 	"    -r, --remote=<host>    List the exportable USB devices on <host>\n"
-	"    -l, --local            List the local USB devices\n";
+	"    -l, --local            List the local USB devices\n"
+	"    -d, --device           List the local USB gadgets bound to usbip-vudc\n";
 
 void usbip_list_usage(void)
 {

Signature · 1 line

2.30.1

Shuah Khan

maintainer Acked-by on v5 1/2

2021-03-24 23:51 UTC #9 lore raw

In reply to Hongren Zheng (Zenithal)

Quoted 143 lines · Hongren Zheng (Zenithal)

The commit e0546fd8b748 ("usbip: tools: Start using VUDC backend in usbip tools") implemented device mode for user space tools, however the corresponding options are not documented in man page.

This commit documents the options and provides examples on device mode. Also the command usbip port is documented.

Signed-off-by Hongren Zheng <[email protected]>

---
  tools/usb/usbip/doc/usbip.8  | 42 +++++++++++++++++++++++++++++++++++-
  tools/usb/usbip/doc/usbipd.8 | 26 ++++++++++++++++++++++
  2 files changed, 67 insertions(+), 1 deletion(-)

PATCH v2:
Add signed-off-by line

PATCH v3:
Move patch changelog after the marker line
Remove nickname in signed-off-by line

PATCH v4:
Use commit short hash and message instead of long hash only when
referring to commit in the kernel

PATCH v5:
Add documentation of usbip port and its usage in examples Add flow of detaching in examples
Rephrase some description and add punctuations Fix typo of usbip attach --ev-id to --dev-id

tools/usb/usbip/doc/usbip.8 +41 -1

index a15d20063b98..1f26e4a00638 100644
@@ -49,10 +49,17 @@ then exit.
  Attach a remote USB device.
  .PP
 
+.HP
+\fBattach\fR \-\-remote=<\fIhost\fR> \-\-device=<\fIdev_id\fR>
+.IP
+Attach a remote USB gadget.
+Only used when the remote usbipd is in device mode.
+.PP
+
  .HP
  \fBdetach\fR \-\-port=<\fIport\fR>
  .IP
-Detach an imported USB device.
+Detach an imported USB device/gadget.
  .PP
 
  .HP

@@ -73,12 +80,26 @@ Stop exporting a device so it can be used by a local driver.
  List USB devices exported by a remote host.
  .PP
 
+.HP
+\fBlist\fR \-\-device
+.IP
+List USB gadgets of local usbip-vudc.
+Only used when the local usbipd is in device mode.
+Note that this can not list usbip-vudc USB gadgets of the remote device mode usbipd.
+.PP
+
  .HP
  \fBlist\fR \-\-local
  .IP
  List local USB devices.
  .PP
 
+.HP
+\fBport\fR
+.IP
+List imported devices/gadgets.
+.PP
+
 
  .SH EXAMPLES

@@ -90,8 +111,27 @@ List local USB devices.
      client:# usbip attach --remote=server --busid=1-2
          - Connect the remote USB device.
 
+    client:# usbip port
+        - List imported devices/gadgets.
+
      client:# usbip detach --port=0
          - Detach the usb device.
 
+The following example shows the usage of device mode
+
+    server:# usbip list --device
+        - List gadgets exported by local usbipd server.
+
+    client:# modprobe vhci-hcd
+
+    client:# usbip attach --remote=server --device=usbip-vudc.0
+        - Connect the remote USB gadget.
+
+    client:# usbip port
+        - List imported devices/gadgets.
+
+    client:# usbip detach --port=0
+        - Detach the usb gadget.
+
  .SH "SEE ALSO"
  \fBusbipd\fP\fB(8)\fB\fP

tools/usb/usbip/doc/usbipd.8 +19 -0

index fb62a756893b..d974394f86a1 100644
@@ -29,6 +29,12 @@ Bind to IPv4. Default is both.
  Bind to IPv6. Default is both.
  .PP
 
+.HP
+\fB\-e\fR, \fB\-\-device\fR
+.IP
+Run in device mode. Rather than drive an attached device, create a virtual UDC to bind gadgets to.
+.PP
+
  .HP
  \fB\-D\fR, \fB\-\-daemon\fR
  .IP

@@ -86,6 +92,26 @@ USB/IP client can connect and use exported devices.
          - A usb device 1-2 is now exportable to other hosts!
          - Use 'usbip unbind --busid=1-2' when you want to shutdown exporting and use the device locally.
 
+The following example shows the usage of device mode
+
+    server:# modprobe usbip-vudc
+        - Use /sys/class/udc/ interface.
+        - usbip-host is independent of this module.
+
+    server:# usbipd -e -D
+        - Start usbip daemon in device mode.
+
+    server:# modprobe g_mass_storage file=/tmp/tmp.img
+        - Bind a gadget to usbip-vudc.
+        - in this example, a mass storage gadget is bound.
+

tools/usb/usbip/doc/usbipd.8 USB/IP client can connect and use exported devices. · line 117

Quoted 10 lines

tools/usb/usbip/doc/usbipd.8 +7 -0

+    server:# usbip list --device
+        - List gadgets exported by local usbipd server.
+
+    server:# modprobe -r g_mass_storage
+        - Unbind a gadget from usbip-vudc.
+        - in this example, the previous mass storage gadget is unbound.
+
  .SH "SEE ALSO"
  \fBusbip\fP\fB(8)\fB\fP

Thank you. Looks good.

Acked-by Shuah Khan <[email protected]>

thanks,
-- Shuah

Shuah Khan

maintainer Acked-by on v5 2/2

2021-03-24 23:52 UTC #8 lore raw

Re: [PATCH v5 2/2] usbip: tools: add usage of device mode in usbip_list.c

In reply to Hongren Zheng (Zenithal)

Quoted 31 lines · Hongren Zheng (Zenithal)

The option '-d/--device' was implemented in 'usbip list' but not shown in usage. Hence this commit adds this option to usage.
Signed-off-by Hongren Zheng <[email protected]>
---
  tools/usb/usbip/src/usbip_list.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
PATCH v2:
Add signed-off-by line
PATCH v3:
Move patch changelog after the marker line
Remove nickname in signed-off-by line
PATCH v4:
Use commit short hash and message instead of long hash only when
referring to commit in the kernel
PATCH v5:
Add documentation of usbip port and its usage in examples Add flow of detaching in examples
Rephrase some description and add punctuations Fix typo of usbip attach --ev-id to --dev-id
tools/usb/usbip/src/usbip_list.c +0 -0
index 8625b0f514ee..3d810bcca02f 100644

tools/usb/usbip/src/usbip_list.c static const char usbip_list_usage_string[] = · line 40

Quoted 9 lines

tools/usb/usbip/src/usbip_list.c +2 -1

@@ -33,7 +33,8 @@ static const char usbip_list_usage_string[] =
  	"usbip list [-p|--parsable] <args>\n"
  	"    -p, --parsable         Parsable list format\n"
  	"    -r, --remote=<host>    List the exportable USB devices on <host>\n"
-	"    -l, --local            List the local USB devices\n";
+	"    -l, --local            List the local USB devices\n"
+	"    -d, --device           List the local USB gadgets bound to usbip-vudc\n";
 
  void usbip_list_usage(void)
  {

Thank you. Looks good.

Acked-by Shuah Khan <[email protected]>

thanks,
-- Shuah