Skip to contentSkip to conversation

staging: rtl8712: added spaces around '+'

PATCH Superseded Mitali Borkar 3 participants 4 messages Apr 8, 2021 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8712: added spaces around '+'

Clean up Check:spaces preferred around that '+' (ctx:VxV) Reported by checkpatch

---
 drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/wlan_bssdef.h +1 -1
index b54ccaacc527..ec3749813728 100644
@@ -176,7 +176,7 @@ struct NDIS_802_11_WEP {
 #define MIC_CHECK_TIME	60000000
 
 #ifndef Ndis802_11APMode
-#define Ndis802_11APMode (Ndis802_11InfrastructureMax+1)
+#define Ndis802_11APMode (Ndis802_11InfrastructureMax + 1)
 #endif
 
 struct	wlan_network {
Signature · 1 line
2.30.2
#1 lore raw

The subject line should be in the imperative, so "add" instead of "added".

Quoted 2 lines · Mitali Borkar

Clean up Check:spaces preferred around that '+' (ctx:VxV) Reported by checkpatch

Please try to rephrase to explain what you did and why. "Clean up" kind of states what the goal is, but your opinion about what is a clean up might be different than someone else's. It's also not necessary to cite the checkpatch warning exactly.

julia

Quoted 27 lines
---
 drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/wlan_bssdef.h +1 -2
index b54ccaacc527..ec3749813728 100644
@@ -176,7 +176,7 @@ struct NDIS_802_11_WEP {
 #define MIC_CHECK_TIME	60000000
 
 #ifndef Ndis802_11APMode
-#define Ndis802_11APMode (Ndis802_11InfrastructureMax+1)
+#define Ndis802_11APMode (Ndis802_11InfrastructureMax + 1)
 #endif
 
 struct	wlan_network {
--

2.30.2

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YG690ZIRdCEcjoM6%40kali.

#2 lore raw
Quoted 2 lines · Julia Lawall

The subject line should be in the imperative, so "add" instead of "added".

Ok Ma'am

Quoted 10 lines · Mitali Borkar
Quoted 3 lines

Clean up Check:spaces preferred around that '+' (ctx:VxV) Reported by checkpatch

Please try to rephrase to explain what you did and why. "Clean up" kind of states what the goal is, but your opinion about what is a clean up might be different than someone else's. It's also not necessary to cite the checkpatch warning exactly.

OKay Ma'am, will rewrite the appopriate commit message. May I know while resending this patch, what should I write in subject description, RESEND PATCH or PATCH v2

Thanks
Mitali

Quoted 29 lines

julia

Quoted 27 lines
---
 drivers/staging/rtl8712/wlan_bssdef.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/wlan_bssdef.h +1 -2
index b54ccaacc527..ec3749813728 100644
@@ -176,7 +176,7 @@ struct NDIS_802_11_WEP {
 #define MIC_CHECK_TIME	60000000
 
 #ifndef Ndis802_11APMode
-#define Ndis802_11APMode (Ndis802_11InfrastructureMax+1)
+#define Ndis802_11APMode (Ndis802_11InfrastructureMax + 1)
 #endif
 
 struct	wlan_network {
--

2.30.2

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YG690ZIRdCEcjoM6%40kali.

maintainer
#3 lore raw
Quoted 9 lines · Mitali Borkar
Quoted 2 lines · Julia Lawall

The subject line should be in the imperative, so "add" instead of "added".

Ok Ma'am

Quoted 5 lines · Mitali Borkar
Quoted 3 lines

Clean up Check:spaces preferred around that '+' (ctx:VxV) Reported by checkpatch

Quoted 8 lines
Quoted 5 lines

Please try to rephrase to explain what you did and why. "Clean up" kind of states what the goal is, but your opinion about what is a clean up might be different than someone else's. It's also not necessary to cite the checkpatch warning exactly.

OKay Ma'am, will rewrite the appopriate commit message. May I know while resending this patch, what should I write in subject description, RESEND PATCH or PATCH v2

"RESEND" is only ok if the patch and changelog text is identical to the previous version and something got lost so it needed to be resent.

I do not think that is the case here.

thanks,

greg k-h