media: zoran: add spaces around '<<'
Subsystems (2)
PATCH v2 1/2 media: zoran: add spaces around '<<'
No changes required in this patch.
In v1:- Added spaces around '<<' operator to improve readability and meet linux kernel coding style
---
Changes from v1:- No changes required in this patch. Below is the git diff of v1.
drivers/staging/media/zoran/zr36057.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/media/zoran/zr36057.h +7 -7
@@ -30,13 +30,13 @@#define ZR36057_VFESPFR_HOR_DCM 14#define ZR36057_VFESPFR_VER_DCM 8#define ZR36057_VFESPFR_DISP_MODE 6 -#define ZR36057_VFESPFR_YUV422 (0<<3) -#define ZR36057_VFESPFR_RGB888 (1<<3) -#define ZR36057_VFESPFR_RGB565 (2<<3) -#define ZR36057_VFESPFR_RGB555 (3<<3) -#define ZR36057_VFESPFR_ERR_DIF (1<<2) -#define ZR36057_VFESPFR_PACK24 (1<<1) -#define ZR36057_VFESPFR_LITTLE_ENDIAN (1<<0) +#define ZR36057_VFESPFR_YUV422 (0 << 3) +#define ZR36057_VFESPFR_RGB888 (1 << 3) +#define ZR36057_VFESPFR_RGB565 (2 << 3) +#define ZR36057_VFESPFR_RGB555 (3 << 3) +#define ZR36057_VFESPFR_ERR_DIF (1 << 2) +#define ZR36057_VFESPFR_PACK24 (1 << 1) +#define ZR36057_VFESPFR_LITTLE_ENDIAN (1 << 0)#define ZR36057_VDTR 0x00c/* Video Display "Top" Register */
Signature · 1 line
2.30.2
Quoted 3 lines · Mitali Borkar
No changes required in this patch.
In v1:- Added spaces around '<<' operator to improve readability and meet linux kernel coding style
The text above would go in the git history. "No changes required in this patch." doesn't make sense in that context. If you want to say something that relates to the history of the submitted patches, then that should be under the ---. The text there will disappear when the patch is applied.
julia
Quoted 43 lines
Signed-off-by Mitali Borkar <[email protected]>---
Changes from v1:- No changes required in this patch. Below is the git diff of v1.
drivers/staging/media/zoran/zr36057.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/staging/media/zoran/zr36057.h +7
-8@@ -30,13 +30,13 @@#define ZR36057_VFESPFR_HOR_DCM 14#define ZR36057_VFESPFR_VER_DCM 8#define ZR36057_VFESPFR_DISP_MODE 6 -#define ZR36057_VFESPFR_YUV422 (0<<3) -#define ZR36057_VFESPFR_RGB888 (1<<3) -#define ZR36057_VFESPFR_RGB565 (2<<3) -#define ZR36057_VFESPFR_RGB555 (3<<3) -#define ZR36057_VFESPFR_ERR_DIF (1<<2) -#define ZR36057_VFESPFR_PACK24 (1<<1) -#define ZR36057_VFESPFR_LITTLE_ENDIAN (1<<0) +#define ZR36057_VFESPFR_YUV422 (0 << 3) +#define ZR36057_VFESPFR_RGB888 (1 << 3) +#define ZR36057_VFESPFR_RGB565 (2 << 3) +#define ZR36057_VFESPFR_RGB555 (3 << 3) +#define ZR36057_VFESPFR_ERR_DIF (1 << 2) +#define ZR36057_VFESPFR_PACK24 (1 << 1) +#define ZR36057_VFESPFR_LITTLE_ENDIAN (1 << 0)#define ZR36057_VDTR 0x00c/* Video Display "Top" Register */ --2.30.2
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHCgksbiLv0pFF2F%40kali.
Quoted 4 lines · Julia Lawall
On Sat, 10 Apr 2021, Mitali Borkar wrote:
Quoted 9 lines
Quoted 3 lines
No changes required in this patch.
In v1:- Added spaces around '<<' operator to improve readability and meet linux kernel coding styleThe text above would go in the git history. "No changes required in this patch." doesn't make sense in that context. If you want to say something that relates to the history of the submitted patches, then that should be under the ---. The text there will disappear when the patch is applied.
Ok Ma'am, I will rectify this mistake and send patch v3 with correct patch body.
Quoted 46 lines
julia
Quoted 43 lines
Signed-off-by Mitali Borkar <[email protected]>---
Changes from v1:- No changes required in this patch. Below is the git diff of v1.
drivers/staging/media/zoran/zr36057.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/staging/media/zoran/zr36057.h +7
-8@@ -30,13 +30,13 @@#define ZR36057_VFESPFR_HOR_DCM 14#define ZR36057_VFESPFR_VER_DCM 8#define ZR36057_VFESPFR_DISP_MODE 6 -#define ZR36057_VFESPFR_YUV422 (0<<3) -#define ZR36057_VFESPFR_RGB888 (1<<3) -#define ZR36057_VFESPFR_RGB565 (2<<3) -#define ZR36057_VFESPFR_RGB555 (3<<3) -#define ZR36057_VFESPFR_ERR_DIF (1<<2) -#define ZR36057_VFESPFR_PACK24 (1<<1) -#define ZR36057_VFESPFR_LITTLE_ENDIAN (1<<0) +#define ZR36057_VFESPFR_YUV422 (0 << 3) +#define ZR36057_VFESPFR_RGB888 (1 << 3) +#define ZR36057_VFESPFR_RGB565 (2 << 3) +#define ZR36057_VFESPFR_RGB555 (3 << 3) +#define ZR36057_VFESPFR_ERR_DIF (1 << 2) +#define ZR36057_VFESPFR_PACK24 (1 << 1) +#define ZR36057_VFESPFR_LITTLE_ENDIAN (1 << 0)#define ZR36057_VDTR 0x00c/* Video Display "Top" Register */ --2.30.2
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHCgksbiLv0pFF2F%40kali.