staging: rtl8188eu: replaced msleep() by usleep_range()
PATCH 1/1 staging: rtl8188eu: replaced msleep() by usleep_range()
Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing msleep(unsigned long msecs) by usleep_range(unsigned long min, unsigned long max) in usecs as msleep(1ms~20ms) can sleep for upto 20 ms.
--- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +1 -1
@@ -5396,7 +5396,7 @@ u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf)return H2C_SUCCESS ;if ((pstapriv->tim_bitmap &BIT (0 )) && (psta_bmc->sleepq_len >0 )) { -msleep (10 );/* 10ms, ATIM(HIQ) Windows */ +usleep_range (10000 ,20000 );/* 10ms, ATIM(HIQ) Windows */ spin_lock_bh (&psta_bmc->sleep_q.lock); xmitframe_phead =get_list_head (&psta_bmc->sleep_q);
Signature · 1 line
2.30.2
Greg KH
maintainerQuoted 14 lines · Mitali Borkar
Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing msleep(unsigned long msecs) by
usleep_range(unsigned long min, unsigned long max)in usecs as msleep(1ms~20ms) can sleep for upto 20 ms.Signed-off-by Mitali Borkar <[email protected]>--- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +0
-0
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf) · line 5399
Quoted 5 lines
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +1
-1@@ -5396,7 +5396,7 @@ u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf)return H2C_SUCCESS ;if ((pstapriv->tim_bitmap &BIT (0 )) && (psta_bmc->sleepq_len >0 )) { -msleep (10 );/* 10ms, ATIM(HIQ) Windows */ +usleep_range (10000 ,20000 );/* 10ms, ATIM(HIQ) Windows */
How do you know you can sleep for 20000 here?
And given that you just changed how the sleep works, are you sure the functionality is the same now?
Only change this type of warning if you have the hardware and can test the change properly.
thanks,
greg k-h
Quoted 17 lines · Greg KH
Quoted 16 lines · Mitali Borkar
Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing msleep(unsigned long msecs) by
usleep_range(unsigned long min, unsigned long max)in usecs as msleep(1ms~20ms) can sleep for upto 20 ms.Signed-off-by Mitali Borkar <[email protected]>--- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +0
-0@@ -5396,7 +5396,7 @@ u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf)return H2C_SUCCESS ;
Quoted 6 lines
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf) · line 5399
Quoted 3 lines
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +1
-1if ((pstapriv->tim_bitmap &BIT (0 )) && (psta_bmc->sleepq_len >0 )) { -msleep (10 );/* 10ms, ATIM(HIQ) Windows */ +usleep_range (10000 ,20000 );/* 10ms, ATIM(HIQ) Windows */ How do you know you can sleep for 20000 here?
When i ran checkpatch.pl it warned that msleep<20 ms can sleep for 20ms. I checked Documentation, it stated that msleep(1ms~20ms) will often sleep longer, ~20ms for any value given in between 1~20ms.
That's why I took 20msec/20000usec as max sleep value.
Quoted 2 lines
And given that you just changed how the sleep works, are you sure the functionality is the same now?
I am still learning, I am not sure about this.
Quoted 7 lines
Only change this type of warning if you have the hardware and can test the change properly.
thanks,
greg k-h