iio: core: Fix an error pointer vs NULL bug in devm_iio_device_alloc()
Subsystems (2)
PATCH 1/1 iio: core: Fix an error pointer vs NULL bug in devm_iio_device_alloc()
The devm_iio_device_alloc() function is supposed to return NULL and not error pointers. Returning an error pointer will lead to a crash in the callers.
Fixes d240dc25e3b8 ("iio: core: simplify some devm functions")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/iio/industrialio-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/industrialio-core.c +1 -1
@@ -1711,7 +1711,7 @@ struct iio_dev *devm_iio_device_alloc(struct device *parent, int sizeof_priv) ret =devm_add_action_or_reset (parent, devm_iio_device_release, iio_dev);if (ret) -return ERR_PTR (ret); +return NULL ;return iio_dev; }
Signature · 1 line
2.30.2
Quoted 5 lines · Dan Carpenter
The
devm_iio_device_alloc()function is supposed to return NULL and not error pointers. Returning an error pointer will lead to a crash in the callers.
oh
that's a good catch;
Reviewed-by Alexandru Ardelean <[email protected]>
Quoted 22 lines
Fixes d240dc25e3b8 ("iio: core: simplify some devm functions")Signed-off-by Dan Carpenter <[email protected]>--- drivers/iio/industrialio-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/industrialio-core.c +1
-2@@ -1711,7 +1711,7 @@ struct iio_dev *devm_iio_device_alloc(struct device *parent, int sizeof_priv) ret =devm_add_action_or_reset (parent, devm_iio_device_release, iio_dev);if (ret) -return ERR_PTR (ret); +return NULL ;return iio_dev; } --2.30.2
Jonathan Cameron
maintainerQuoted 11 lines · On Sun, 16 May 2021 08:30:20 +0300 Alexandru Ardelean <[email protected]>…
Quoted 5 lines · Dan Carpenter
The
devm_iio_device_alloc()function is supposed to return NULL and not error pointers. Returning an error pointer will lead to a crash in the callers.oh
that's a good catch;Reviewed-by Alexandru Ardelean <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it.
Thanks,
Jonathan
Quoted 23 lines
Quoted 23 lines
Fixes d240dc25e3b8 ("iio: core: simplify some devm functions")Signed-off-by Dan Carpenter <[email protected]>--- drivers/iio/industrialio-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/industrialio-core.c +1
-2@@ -1711,7 +1711,7 @@ struct iio_dev *devm_iio_device_alloc(struct device *parent, int sizeof_priv) ret =devm_add_action_or_reset (parent, devm_iio_device_release, iio_dev);if (ret) -return ERR_PTR (ret); +return NULL ;return iio_dev; } --2.30.2