net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()
Subsystems (5)
PATCH 1/1 net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()
These functions return negative ENODATA but the minus sign was left out in the tests.
Fixes f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics")
Signed-off-by Dan Carpenter <[email protected]>
--- net/smc/smc_stats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
net/smc/smc_stats.c +3 -3
@@ -393,17 +393,17 @@ int smc_nl_get_fback_stats(struct sk_buff *skb, struct netlink_callback *cb)continue ;if (!skip_serv) { rc_srv =smc_nl_get_fback_details (skb, cb, k, is_srv); -if (rc_srv && rc_srv !=ENODATA ) +if (rc_srv && rc_srv != -ENODATA )break ; }else { skip_serv =0 ; } rc_clnt =smc_nl_get_fback_details (skb, cb, k, !is_srv); -if (rc_clnt && rc_clnt !=ENODATA ) { +if (rc_clnt && rc_clnt != -ENODATA ) { skip_serv =1 ;break ; } -if (rc_clnt ==ENODATA && rc_srv ==ENODATA ) +if (rc_clnt == -ENODATA && rc_srv == -ENODATA )break ; }mutex_unlock (&net->smc.mutex_fback_rsn);
Signature · 1 line
2.30.2
Quoted 24 lines · Dan Carpenter
These functions return negative ENODATA but the minus sign was left out in the tests.
Fixes f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics")Signed-off-by Dan Carpenter <[email protected]>--- net/smc/smc_stats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)net/smc/smc_stats.c +1
-1@@ -393,17 +393,17 @@ int smc_nl_get_fback_stats(struct sk_buff *skb, struct netlink_callback *cb)continue ;if (!skip_serv) { rc_srv =smc_nl_get_fback_details (skb, cb, k, is_srv); -if (rc_srv && rc_srv !=ENODATA ) +if (rc_srv && rc_srv != -ENODATA )break ; }else { skip_serv =0 ; } rc_clnt =smc_nl_get_fback_details (skb, cb, k, !is_srv);
net/smc/smc_stats.c int smc_nl_get_fback_stats(struct sk_buff *skb, struct netlink_callback *cb) · line 409
Quoted 10 lines
net/smc/smc_stats.c +2
-2-if (rc_clnt && rc_clnt !=ENODATA ) { +if (rc_clnt && rc_clnt != -ENODATA ) { skip_serv =1 ;break ; } -if (rc_clnt ==ENODATA && rc_srv ==ENODATA ) +if (rc_clnt == -ENODATA && rc_srv == -ENODATA )break ; }mutex_unlock (&net->smc.mutex_fback_rsn);
Acked-by Guvenc Gulce <[email protected]>
Thanks for preparing the fix.
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 8 lines · On Sat, 19 Jun 2021 16:50:21 +0300 you wrote:
These functions return negative ENODATA but the minus sign was left out in the tests.
Fixes f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics")Signed-off-by Dan Carpenter <[email protected]>--- net/smc/smc_stats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
- [net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()
https://git.kernel.org/netdev/net-next/c/1a1100d53f12
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html