Skip to contentSkip to conversation

net: iosm: remove an unnecessary NULL check

PATCH Applied Dan Carpenter 3 participants 3 messages Jun 19, 2021 – Jun 21, 2021

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: iosm: remove an unnecessary NULL check

The address of &ipc_mux->ul_adb can't be NULL because it points to the middle of a non-NULL struct.

Fixes 9413491e20e1 ("net: iosm: encode or decode datagram")
---
 drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wwan/iosm/iosm_ipc_mux_codec.c +1 -1
index fbf3cab3394c..e634ffc6ec08 100644
@@ -477,7 +477,7 @@ static void ipc_mux_ul_adgh_finish(struct iosm_mux *ipc_mux)
 	long long bytes;
 	char *str;
 
-	if (!ul_adb || !ul_adb->dest_skb) {
+	if (!ul_adb->dest_skb) {
 		dev_err(ipc_mux->dev, "no dest skb");
 		return;
 	}
Signature · 1 line
2.30.2
#2 lore raw
In reply to Dan Carpenter
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 8 lines · On Sat, 19 Jun 2021 16:51:26 +0300 you wrote:

The address of &ipc_mux->ul_adb can't be NULL because it points to the middle of a non-NULL struct.

Fixes 9413491e20e1 ("net: iosm: encode or decode datagram")
---
 drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [net-next] net: iosm: remove an unnecessary NULL check

    https://git.kernel.org/netdev/net-next/c/d5fff4629bea

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html