Skip to contentSkip to conversation

memory: tegra: Delete dead debugfs checking code

PATCH Applied Dan Carpenter 2 participants 2 messages Jun 9, 2021 – Jun 10, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memory: tegra: Delete dead debugfs checking code

The debugfs_create_dir() function does not return NULL, it returns error pointers. But in normal situations like this where the caller is not dereferencing "emc->debugfs.root" then we are not supposed to check the return. So instead of fixing these checks, we should delete them.

---
 drivers/memory/tegra/tegra124-emc.c      | 4 ----
 drivers/memory/tegra/tegra20-emc.c       | 4 ----
 drivers/memory/tegra/tegra210-emc-core.c | 4 ----
 drivers/memory/tegra/tegra30-emc.c       | 4 ----
 4 files changed, 16 deletions(-)
drivers/memory/tegra/tegra124-emc.c +0 -4
index a21ca8e0841a..908f8d5392b2 100644
@@ -1269,10 +1269,6 @@ static void emc_debugfs_init(struct device *dev, struct tegra_emc *emc)
 	}
 
 	emc->debugfs.root = debugfs_create_dir("emc", NULL);
-	if (!emc->debugfs.root) {
-		dev_err(dev, "failed to create debugfs directory\n");
-		return;
-	}
 
 	debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc,
 			    &tegra_emc_debug_available_rates_fops);
drivers/memory/tegra/tegra20-emc.c +0 -4
index a534197a5fb2..c3462dbc8c22 100644
@@ -776,10 +776,6 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
 	}
 
 	emc->debugfs.root = debugfs_create_dir("emc", NULL);
-	if (!emc->debugfs.root) {
-		dev_err(emc->dev, "failed to create debugfs directory\n");
-		return;
-	}
 
 	debugfs_create_file("available_rates", 0444, emc->debugfs.root,
 			    emc, &tegra_emc_debug_available_rates_fops);
drivers/memory/tegra/tegra210-emc-core.c +0 -4
index 5f224796e32e..06c0f17fa429 100644
@@ -1759,10 +1759,6 @@ static void tegra210_emc_debugfs_init(struct tegra210_emc *emc)
 	}
 
 	emc->debugfs.root = debugfs_create_dir("emc", NULL);
-	if (!emc->debugfs.root) {
-		dev_err(dev, "failed to create debugfs directory\n");
-		return;
-	}
 
 	debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc,
 			    &tegra210_emc_debug_available_rates_fops);
drivers/memory/tegra/tegra30-emc.c +0 -4
index 63e1983f8a0d..7e21a852f2e1 100644
@@ -1354,10 +1354,6 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
 	}
 
 	emc->debugfs.root = debugfs_create_dir("emc", NULL);
-	if (!emc->debugfs.root) {
-		dev_err(emc->dev, "failed to create debugfs directory\n");
-		return;
-	}
 
 	debugfs_create_file("available_rates", 0444, emc->debugfs.root,
 			    emc, &tegra_emc_debug_available_rates_fops);
Signature · 1 line
2.30.2
#1 lore raw
Quoted 4 lines · Dan Carpenter

The debugfs_create_dir() function does not return NULL, it returns error pointers. But in normal situations like this where the caller is not dereferencing "emc->debugfs.root" then we are not supposed to check the return. So instead of fixing these checks, we should delete them.

Applied, thanks!

[1/1] memory: tegra: Delete dead debugfs checking code

      commit: c7c65703260c88a3e4d7387b2d03023c3625c6d4

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>