Skip to contentSkip to conversation

spi: hisi-kunpeng: Delete some dead code

PATCH New Dan Carpenter 1 participant 1 message Jun 10, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: hisi-kunpeng: Delete some dead code

The debugfs_create_dir() function returns error pointers, it doesn't return NULL. But debugfs functions aren't supposed to be checked in normal circumstancers where the driver doesn't dereference the pointer itself.

Fixes 2b2142f247eb ("spi: hisi-kunpeng: Add debugfs support")
---
 drivers/spi/spi-hisi-kunpeng.c | 2 --
 1 file changed, 2 deletions(-)
drivers/spi/spi-hisi-kunpeng.c +0 -2
index 58b823a16fc4..875f337a7836 100644
@@ -167,8 +167,6 @@ static int hisi_spi_debugfs_init(struct hisi_spi *hs)
 
 	snprintf(name, 32, "hisi_spi%d", hs->bus_num);
 	hs->debugfs = debugfs_create_dir(name, NULL);
-	if (!hs->debugfs)
-		return -ENOMEM;
 
 	hs->regset.regs = hisi_spi_regs;
 	hs->regset.nregs = ARRAY_SIZE(hisi_spi_regs);
Signature · 1 line
2.30.2