cifs: fix NULL dereference in smb2_check_message()
Subsystems (3)
PATCH 1/1 cifs: fix NULL dereference in smb2_check_message()
This code sets "ses" to NULL which will lead to a NULL dereference on the second iteration through the loop.
Fixes 85346c17e425 ("cifs: convert list_for_each to entry variant in smb2misc.c")
Signed-off-by Dan Carpenter <[email protected]>
--- fs/cifs/smb2misc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
fs/cifs/smb2misc.c +2 -3
@@ -158,11 +158,10 @@ smb2_check_message(char *buf, unsigned int len, struct TCP_Server_Info *srvr)list_for_each_entry (ses, &srvr->smb_ses_list, smb_ses_list) {if (ses->Suid == thdr->SessionId)break ; - - ses =NULL ; }spin_unlock (&cifs_tcp_ses_lock); -if (ses ==NULL ) { +if (list_entry_is_head (ses, &srvr->smb_ses_list, + smb_ses_list)) {cifs_dbg (VFS ,"no decryption - session id not found\n" );return 1 ; }
Signature · 1 line
2.30.2
Reviewed-by Aurelien Aptel <[email protected]>
Signature · 4 lines
Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)