ALSA: hdsp: fix a test for copy_to_user() failure
Subsystems (2)
PATCH 1/1 ALSA: hdsp: fix a test for copy_to_user() failure
The copy_to_user() function returns the number of bytes remaining to be copied. It doesn't return negatives.
Fixes 66c8f75919dd ("ALSA: hdsp: Fix assignment in if condition")
Signed-off-by Dan Carpenter <[email protected]>
--- sound/pci/rme9652/hdsp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
sound/pci/rme9652/hdsp.c +2 -3
@@ -4877,9 +4877,8 @@ static int snd_hdsp_hwdep_ioctl(struct snd_hwdep *hw, struct file *file, unsignememset (&hdsp_version,0 ,sizeof (hdsp_version)); hdsp_version.io_type = hdsp->io_type; hdsp_version.firmware_rev = hdsp->firmware_rev; - err =copy_to_user (argp, &hdsp_version,sizeof (hdsp_version)); -if (err <0 ) -return -EFAULT ; +if (copy_to_user (argp, &hdsp_version,sizeof (hdsp_version))) +return -EFAULT ;break ; }case SNDRV_HDSP_IOCTL_UPLOAD_FIRMWARE : {
Signature · 1 line
2.30.2
Takashi Iwai
AppliedQuoted 6 lines · Dan Carpenter
The
copy_to_user()function returns the number of bytes remaining to be copied. It doesn't return negatives.Fixes 66c8f75919dd ("ALSA: hdsp: Fix assignment in if condition")Signed-off-by Dan Carpenter <[email protected]>
Thanks, applied.
Takashi