rpcbind: Remove 0001-Remove-yellow-pages-support.patch
Hi Thomas,
I'm thinking about removing package/rpcbind/0001-Remove-yellow-pages-support.patch patch.
It was originally added in 2012 in 8bc245da21 ("rpcbind: new package").
At the time constants YPBINDPROC_SETDOM, YPPROG, YPPASSWDPROG were missing in rpcbind (added in 2015 in rpcbind commit 9e0c7ac ("configure.ac: Check for rpcsvc/mount.h").
I'll verify it, but I'll strongly suspect the only problem was in these missing constants and very old libtirpc. Thus it should be working now. Probably the best approach would be to disable legacy yellow pages in upstream, I can ask for some configure switch. But if you're don't require it, I'd just drop the patch which is not needed any more.
Patch was also somehow related to package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch (originally added as package/libtirpc/libtirpc-0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch), which was removed in 883a33ece5 ("libtirpc: remove NIS patch") as not needed.
Kind regards,
Petr
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Hello Petr,
Quoted 13 lines · On Sun, 25 Jul 2021 22:14:53 +0200 Petr Vorel <[email protected]> wrote:
I'm thinking about removing
package/rpcbind/0001-Remove-yellow-pages-support.patchpatch.It was originally added in 2012 in
8bc245da21("rpcbind: new package").
At the time constantsYPBINDPROC_SETDOM, YPPROG, YPPASSWDPROG were missing in rpcbind (added in 2015 in rpcbind commit 9e0c7ac ("configure.ac: Check forrpcsvc/mount.h").I'll verify it, but I'll strongly suspect the only problem was in these missing constants and very old libtirpc. Thus it should be working now. Probably the best approach would be to disable legacy yellow pages in upstream, I can ask for some configure switch. But if you're don't require it, I'd just drop the patch which is not needed any more.
Quoted 3 lines
Patch was also somehow related to
package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch(originally added aspackage/libtirpc/libtirpc-0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch), which was removed in883a33ece5("libtirpc: remove NIS patch") as not needed.
Sure, if it all builds/works fine with a more recent libtirpc, I'm all fine with dropping this patch!
Best regards,
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] http://lists.busybox.net/mailman/listinfo/buildroot
Hi Thomas,
Quoted 18 lines
Hello Petr,
Quoted 12 lines · On Sun, 25 Jul 2021 22:14:53 +0200 Petr Vorel <[email protected]> wrote:
I'm thinking about removing
package/rpcbind/0001-Remove-yellow-pages-support.patchpatch.It was originally added in 2012 in
8bc245da21("rpcbind: new package").
At the time constantsYPBINDPROC_SETDOM, YPPROG, YPPASSWDPROG were missing in rpcbind (added in 2015 in rpcbind commit 9e0c7ac ("configure.ac: Check forrpcsvc/mount.h").I'll verify it, but I'll strongly suspect the only problem was in these missing constants and very old libtirpc. Thus it should be working now. Probably the best approach would be to disable legacy yellow pages in upstream, I can ask for some configure switch. But if you're don't require it, I'd just drop the patch which is not needed any more.
Quoted 6 lines
Quoted 3 lines
Patch was also somehow related to
package/libtirpc/0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch(originally added aspackage/libtirpc/libtirpc-0001-Disable-parts-of-TIRPC-requiring-NIS-support.patch), which was removed in883a33ece5("libtirpc: remove NIS patch") as not needed.Sure, if it all builds/works fine with a more recent libtirpc, I'm all fine with dropping this patch!
Thanks! I'll verify it and send patch or report if still needed.
Kind regards,
Petr
Quoted 3 lines
Best regards,
Thomas
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot