staging: r8188eu: core: remove condition with no effect

PATCH In review Saurav Girepunje 3 participants 3 messages Aug 29, 2021 Staging

Share & tools

Saurav Girepunje

author

2021-08-29 09:01 UTC #0 lore raw

PATCH 1/1 staging: r8188eu: core: remove condition with no effect

Remove the condition with no effect (if == else) and group multiple cases which execute same statement in rtw_mlme_ext.c

Signed-off-by Saurav Girepunje <[email protected]>

---
 drivers/staging/r8188eu/core/rtw_mlme_ext.c | 9 ---------
 1 file changed, 9 deletions(-)

drivers/staging/r8188eu/core/rtw_mlme_ext.c +0 -9

index 5a472a4954b0..4178b3c1ff57 100644
@@ -453,17 +453,8 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)
 		fallthrough;
 	case WIFI_ASSOCREQ:
 	case WIFI_REASSOCREQ:
-		_mgt_dispatcher(padapter, ptable, precv_frame);
-		break;
 	case WIFI_PROBEREQ:
-		if (check_fwstate(pmlmepriv, WIFI_AP_STATE))
-			_mgt_dispatcher(padapter, ptable, precv_frame);
-		else
-			_mgt_dispatcher(padapter, ptable, precv_frame);
-		break;
 	case WIFI_BEACON:
-		_mgt_dispatcher(padapter, ptable, precv_frame);
-		break;
 	case WIFI_ACTION:
 		_mgt_dispatcher(padapter, ptable, precv_frame);
 		break;

--
2.32.0

Pavel Skripkin

Reviewed-by on v1 1/1

2021-08-29 12:08 UTC #1 lore raw

Quoted 4 lines · Saurav Girepunje

Remove the condition with no effect (if == else) and group multiple cases which execute same statement in rtw_mlme_ext.c
Signed-off-by Saurav Girepunje <[email protected]>

Reviewed-by Pavel Skripkin <[email protected]>

Michael Straube

Acked-by on v1 1/1

2021-08-29 12:48 UTC #2 lore raw

In reply to Saurav Girepunje

Quoted 31 lines · Saurav Girepunje

Remove the condition with no effect (if == else) and group multiple cases which execute same statement in rtw_mlme_ext.c

Signed-off-by Saurav Girepunje <[email protected]>

---
  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 9 ---------
  1 file changed, 9 deletions(-)

drivers/staging/r8188eu/core/rtw_mlme_ext.c +0 ~~-10~~

index 5a472a4954b0..4178b3c1ff57 100644
@@ -453,17 +453,8 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)
  		fallthrough;
  	case WIFI_ASSOCREQ:
  	case WIFI_REASSOCREQ:
-		_mgt_dispatcher(padapter, ptable, precv_frame);
-		break;
  	case WIFI_PROBEREQ:
-		if (check_fwstate(pmlmepriv, WIFI_AP_STATE))
-			_mgt_dispatcher(padapter, ptable, precv_frame);
-		else
-			_mgt_dispatcher(padapter, ptable, precv_frame);
-		break;
  	case WIFI_BEACON:
-		_mgt_dispatcher(padapter, ptable, precv_frame);
-		break;
  	case WIFI_ACTION:
  		_mgt_dispatcher(padapter, ptable, precv_frame);
  		break;
--

Quoted 2 lines

2.32.0

Acked-by Michael Straube <[email protected]>

Thanks,
Michael