staging: r8188eu: core: remove condition never execute
PATCH 1/1 staging: r8188eu: core: remove condition never execute
Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.
Signed-off-by Saurav Girepunje <[email protected]>
--- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/r8188eu/core/rtw_mlme_ext.c +0 -3
@@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16else if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE )SetToDs (fctrl); -if (pattrib->mdata) -SetMData (fctrl); - qc = (unsigned short *)(pframe + pattrib->hdrlen -2 );SetPriority (qc, tid);
--
2.32.0
Quoted 24 lines · Saurav Girepunje
Remove condition which never get execute.
aspattrib->mdatais always zero before if condition check.Signed-off-by Saurav Girepunje <[email protected]>--- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 --- 1 file changed, 3 deletions(-)drivers/staging/r8188eu/core/rtw_mlme_ext.c +0
-4@@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16else if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE )SetToDs (fctrl); -if (pattrib->mdata) -SetMData (fctrl); - qc = (unsigned short *)(pframe + pattrib->hdrlen -2 );SetPriority (qc, tid); --
Quoted 2 lines
2.32.0
Thanks for this.
Acked-by Phillip Potter <[email protected]>
Regards,
Phil
Quoted 23 lines · Saurav Girepunje
Remove condition which never get execute.
aspattrib->mdatais always zero before if condition check.Signed-off-by Saurav Girepunje <[email protected]>--- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 --- 1 file changed, 3 deletions(-)drivers/staging/r8188eu/core/rtw_mlme_ext.c +0
-4@@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16else if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE )SetToDs (fctrl); -if (pattrib->mdata) -SetMData (fctrl); - qc = (unsigned short *)(pframe + pattrib->hdrlen -2 );SetPriority (qc, tid); --
Quoted 2 lines
2.32.0
Looks good to me.
Acked-by Michael Straube <[email protected]>
Thanks,
Michael