Skip to contentSkip to conversation

staging: r8188eu: core: remove condition never execute

PATCH In review Saurav Girepunje 3 participants 3 messages Sep 4, 2021 – Sep 5, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: r8188eu: core: remove condition never execute

Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.

---
 drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/r8188eu/core/rtw_mlme_ext.c +0 -3
index 4178b3c1ff57..f314f55997bf 100644
@@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
 	else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
 		SetToDs(fctrl);
 
-	if (pattrib->mdata)
-		SetMData(fctrl);
-
 	qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
 
 	SetPriority(qc, tid);

--
2.32.0

Acked-by on v1 1/1
#1 lore raw
Quoted 24 lines · Saurav Girepunje

Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.

---
 drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/r8188eu/core/rtw_mlme_ext.c +0 -4
index 4178b3c1ff57..f314f55997bf 100644
@@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
        else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
                SetToDs(fctrl);
 
-       if (pattrib->mdata)
-               SetMData(fctrl);
-
        qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
 
        SetPriority(qc, tid);
--
Quoted 2 lines

2.32.0

Thanks for this.

Regards,
Phil

Acked-by on v1 1/1
#2 lore raw
In reply to Saurav Girepunje
Quoted 23 lines · Saurav Girepunje

Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.

---
  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
  1 file changed, 3 deletions(-)
drivers/staging/r8188eu/core/rtw_mlme_ext.c +0 -4
index 4178b3c1ff57..f314f55997bf 100644
@@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
  	else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
  		SetToDs(fctrl);
 
-	if (pattrib->mdata)
-		SetMData(fctrl);
-
  	qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
 
  	SetPriority(qc, tid);
--
Quoted 2 lines

2.32.0

Looks good to me.

Thanks,
Michael