Skip to contentSkip to conversation

staging: r8188eu: core: remove unused variable pAdapter

PATCH Superseded Saurav Girepunje 2 participants 3 messages Oct 2, 2021 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: r8188eu: core: remove unused variable pAdapter

Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.

---
 drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/r8188eu/core/rtw_efuse.c +3 -4
index 801887f497cf..d33a5b3b4088 100644
@@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
 #define REG_EFUSE_CTRL		0x0030
 #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */
 
-static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
-					   u16 Offset,
+static bool Efuse_Read1ByteFromFakeContent(u16 Offset,
 					   u8 *Value)
 {
 	if (Offset >= EFUSE_MAX_HW_SIZE)
@@ -96,7 +95,7 @@ ReadEFuseByte(
 	u16 retry;
 
 	if (pseudo) {
-		Efuse_Read1ByteFromFakeContent(Adapter, _offset, pbuf);
+		Efuse_Read1ByteFromFakeContent(_offset, pbuf);
 		return;
 	}
 
@@ -134,7 +133,7 @@ u8 efuse_OneByteRead(struct adapter *pAdapter, u16 addr, u8 *data, bool pseudo)
 	u8 result;
 
 	if (pseudo) {
-		result = Efuse_Read1ByteFromFakeContent(pAdapter, addr, data);
+		result = Efuse_Read1ByteFromFakeContent(addr, data);
 		return result;
 	}
 	/*  -----------------e-fuse reg ctrl --------------------------------- */

--
2.32.0

#1 lore raw

Thanks for you patch Saurav, just some minor style issue.

Quoted 12 lines · Saurav Girepunje

Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.

---
  drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/r8188eu/core/rtw_efuse.c +0 -0
index 801887f497cf..d33a5b3b4088 100644

drivers/staging/r8188eu/core/rtw_efuse.c u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0}; · line 32

Quoted 7 lines
drivers/staging/r8188eu/core/rtw_efuse.c +1 -2
@@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
  #define REG_EFUSE_CTRL		0x0030
  #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */
 
-static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
-					   u16 Offset,
+static bool Efuse_Read1ByteFromFakeContent(u16 Offset,
  					   u8 *Value)

There is no need for a line break here. ^

Other than that looks good to me.

Thanks,
Michael

#2 lore raw
Quoted 25 lines · Michael Straube

Thanks for you patch Saurav, just some minor style issue.

Quoted 12 lines · Saurav Girepunje

Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.

---
  drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++----

  1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/r8188eu/core/rtw_efuse.c +0 -0
index 801887f497cf..d33a5b3b4088 100644

drivers/staging/r8188eu/core/rtw_efuse.c u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0}; · line 32

Quoted 7 lines
drivers/staging/r8188eu/core/rtw_efuse.c +1 -2
@@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
   #define REG_EFUSE_CTRL        0x0030
   #define EFUSE_CTRL            REG_EFUSE_CTRL        /*  E-Fuse Control. */
 
-static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
-                       u16 Offset,
+static bool Efuse_Read1ByteFromFakeContent(u16 Offset,
                          u8 *Value)

There is no need for a line break here.                 ^

Quoted 4 lines

Other than that looks good to me.

Thanks,
Michael

Thanks Michael for review. Yes line break not needed here. I will update. I will resend the patch.

Regards,
Saurav