Skip to contentSkip to conversation

staging: rtl8723bs: core: remove condition never execute

PATCH In review Saurav Girepunje 2 participants 2 messages Oct 3, 2021 – Oct 4, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: core: remove condition never execute

Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.

---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -3
index b2c042c36777..3ee4d35ca8d7 100644
@@ -3222,9 +3222,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da,
 	else if ((pmlmeinfo->state&0x03) == WIFI_FW_STATION_STATE)
 		SetToDs(fctrl);
 
-	if (pattrib->mdata)
-		SetMData(fctrl);
-
 	qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
 
 	SetPriority(qc, tid);

--
2.32.0

Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 4 lines · Saurav Girepunje

Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.

Thanks, patch looks good to me:

Regards,

Hans

Quoted 21 lines
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -4
index b2c042c36777..3ee4d35ca8d7 100644
@@ -3222,9 +3222,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da,
 	else if ((pmlmeinfo->state&0x03) == WIFI_FW_STATION_STATE)
 		SetToDs(fctrl);
 
-	if (pattrib->mdata)
-		SetMData(fctrl);
-
 	qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
 
 	SetPriority(qc, tid);
--

2.32.0