Skip to contentSkip to conversation

staging: rtl8723bs: core: remove reassignment of same value to variable

PATCH In review Saurav Girepunje 2 participants 2 messages Oct 3, 2021 – Oct 4, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: core: remove reassignment of same value to variable

Remove reassignment of same value to variable pstat->auth_seq. On if (seq == 1) assigning the value 2. At the end of if statement also assigning the value pstat->auth_seq = seq + 1 that is again assigning the value 2.

---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -1
index 3ee4d35ca8d7..059cd85f4b03 100644
@@ -808,7 +808,6 @@ unsigned int OnAuth(struct adapter *padapter, union recv_frame *precv_frame)
 			pstat->state &= ~WIFI_FW_AUTH_NULL;
 			pstat->state |= WIFI_FW_AUTH_STATE;
 			pstat->authalg = algorithm;
-			pstat->auth_seq = 2;
 		} else if (seq == 3) {
 
 			p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&ie_len,

--
2.32.0

Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 15 lines · Saurav Girepunje

Remove reassignment of same value to variable pstat->auth_seq. On if (seq == 1) assigning the value 2. At the end of if statement also assigning the value pstat->auth_seq = seq + 1 that is again assigning the value 2.

---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -0
index 3ee4d35ca8d7..059cd85f4b03 100644

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c unsigned int OnAuth(struct adapter *padapter, union recv_frame *precv_frame) · line 811

Quoted 4 lines
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -1
@@ -808,7 +808,6 @@ unsigned int OnAuth(struct adapter *padapter, union recv_frame *precv_frame)
 			pstat->state &= ~WIFI_FW_AUTH_NULL;
 			pstat->state |= WIFI_FW_AUTH_STATE;
 			pstat->authalg = algorithm;
-			pstat->auth_seq = 2;

Thanks, patch looks good to me:

Regards,

Hans

Quoted 6 lines
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -1
 		} else if (seq == 3) {
 
 			p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&ie_len,
--

2.32.0