Skip to contentSkip to conversation

staging: rtl8723bs: hal: remove duplicate check

PATCH In review Saurav Girepunje 2 participants 2 messages Oct 10, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: hal: remove duplicate check

Remove 'bPerformance' from if condition check. As on previous if condition it is already check for same variable.

---
 drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/odm_DIG.c +1 -1
index beda7b8a7c6a..7e92c373cddb 100644
@@ -544,7 +544,7 @@ void odm_DIG(void *pDM_VOID)
 	/* 1 Adjust initial gain by false alarm */
 	if (pDM_Odm->bLinked && bPerformance) {
 
-		if (bFirstTpTarget || (FirstConnect && bPerformance)) {
+		if (bFirstTpTarget || FirstConnect) {
 			pDM_DigTable->LargeFAHit = 0;
 
 			if (pDM_Odm->RSSI_Min < DIG_MaxOfMin) {

--
2.32.0

Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 4 lines · Saurav Girepunje

Remove 'bPerformance' from if condition check. As on previous if condition it is already check for same variable.

Thanks, patch looks good to me:

Regards,

Hans

Quoted 20 lines
---
 drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/odm_DIG.c +1 -2
index beda7b8a7c6a..7e92c373cddb 100644
@@ -544,7 +544,7 @@ void odm_DIG(void *pDM_VOID)
 	/* 1 Adjust initial gain by false alarm */
 	if (pDM_Odm->bLinked && bPerformance) {
 
-		if (bFirstTpTarget || (FirstConnect && bPerformance)) {
+		if (bFirstTpTarget || FirstConnect) {
 			pDM_DigTable->LargeFAHit = 0;
 
 			if (pDM_Odm->RSSI_Min < DIG_MaxOfMin) {
--

2.32.0