Input: cpcap-pwrbutton - do not set input parent explicitly
Subsystems (2)
Dmitry Torokhov
maintainerPATCH 1/1 Input: cpcap-pwrbutton - do not set input parent explicitly
We are using devm_input_allocate_device() that already sets parent of the input device, there is no need to do that again.
Signed-off-by Dmitry Torokhov <[email protected]>
--- drivers/input/misc/cpcap-pwrbutton.c | 1 - 1 file changed, 1 deletion(-)
drivers/input/misc/cpcap-pwrbutton.c +0 -1
@@ -77,7 +77,6 @@ static int cpcap_power_button_probe(struct platform_device *pdev) button->idev->name ="cpcap-pwrbutton" ; button->idev->phys ="cpcap-pwrbutton/input0" ; - button->idev->dev.parent = button->dev;input_set_capability (button->idev,EV_KEY ,KEY_POWER ); err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
Signature · 5 lines
2.33.0.1079.g6e70778dc9-goog -- Dmitry
Hi,
Quoted 5 lines · Dmitry Torokhov
We are using
devm_input_allocate_device()that already sets parent of the input device, there is no need to do that again.Signed-off-by Dmitry Torokhov <[email protected]>---
Reviewed-by Sebastian Reichel <[email protected]>
-- Sebastian
Quoted 21 lines
drivers/input/misc/cpcap-pwrbutton.c | 1 - 1 file changed, 1 deletion(-)drivers/input/misc/cpcap-pwrbutton.c +0
-1@@ -77,7 +77,6 @@ static int cpcap_power_button_probe(struct platform_device *pdev) button->idev->name ="cpcap-pwrbutton" ; button->idev->phys ="cpcap-pwrbutton/input0" ; - button->idev->dev.parent = button->dev;input_set_capability (button->idev,EV_KEY ,KEY_POWER ); err = devm_request_threaded_irq(&pdev->dev, irq, NULL,Signature · 5 lines
2.33.0.1079.g6e70778dc9-goog -- Dmitry