Skip to contentSkip to conversation

Apply a52f8a59aef46b59753e583bf4b28fccb069ce64 to 5.15 through 4.19

DISCUSSION Nathan Chancellor 3 participants 3 messages Nov 15, 2021 – Nov 19, 2021 Stable branch

lore
Share & tools
lore
#1 lore raw
Quoted 11 lines · Nathan Chancellor

Hi Greg and Sasha,

There is a build error with newer versions of clang due to a broken FORTIFY_SOURCE implementation, which has never worked:

https://github.com/ClangBuiltLinux/linux/issues/1496
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1457787760

Please apply upstream commit a52f8a59aef4 ("fortify: Explicitly disable Clang support") to 5.15 through 4.19 to resolve this. It should apply cleanly.

Hah! Oh the Android people are going to _LOVE_ this one...

{sigh}

I'll go do this now...

greg k-h

#2 lore raw
Quoted 6 lines · Greg Kroah-Hartman
Quoted 5 lines · Nathan Chancellor

Hi Greg and Sasha,

There is a build error with newer versions of clang due to a broken FORTIFY_SOURCE implementation, which has never worked:

Quoted 8 lines
Quoted 6 lines

https://github.com/ClangBuiltLinux/linux/issues/1496
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1457787760

Please apply upstream commit a52f8a59aef4 ("fortify: Explicitly disable Clang support") to 5.15 through 4.19 to resolve this. It should apply cleanly.

Hah! Oh the Android people are going to _LOVE_ this one...

They (we) are already aware[1]. Fortify has always been broken under Clang, so really this doesn't change anything for Android builds. :P

But yes, one of many motivations of the recent memcpy and fortify work has been to get fortify fixed for Clang. Hopefully this will be all done by 5.17.

-Kees

[1] https://github.com/KSPP/linux/issues/77

Signature · 1 line
Kees Cook